Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/browser/search/contextual_search_promo_source_android.cc

Issue 597673003: [Search] Make the feature name link to a learn more screen in the first-run experience. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/contextual_search/promo.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search/contextual_search_promo_source_android.cc
diff --git a/chrome/browser/search/contextual_search_promo_source_android.cc b/chrome/browser/search/contextual_search_promo_source_android.cc
index 8a93de37a4bc716f35025bcfeacf9c7aff0b0848..7cf96e18ff1c6c068b10426c87ffff9fdb9618dc 100644
--- a/chrome/browser/search/contextual_search_promo_source_android.cc
+++ b/chrome/browser/search/contextual_search_promo_source_android.cc
@@ -87,9 +87,17 @@ void ContextualSearchPromoSourceAndroid::SendResource(
void ContextualSearchPromoSourceAndroid::SendHtmlWithStrings(
const content::URLDataSource::GotDataCallback& callback) {
base::DictionaryValue strings_data;
+ // The three following statements are part of the description paragraph.
strings_data.SetString(
- "description",
- l10n_util::GetStringUTF16(IDS_CONTEXTUAL_SEARCH_PROMO_DESCRIPTION));
+ "description-1",
+ l10n_util::GetStringUTF16(IDS_CONTEXTUAL_SEARCH_PROMO_DESCRIPTION_1));
+ strings_data.SetString(
+ "feature-name",
+ l10n_util::GetStringUTF16(IDS_CONTEXTUAL_SEARCH_PROMO_FEATURE_NAME));
+ strings_data.SetString(
+ "description-2",
+ l10n_util::GetStringUTF16(IDS_CONTEXTUAL_SEARCH_PROMO_DESCRIPTION_2));
+
strings_data.SetString(
"heading", l10n_util::GetStringUTF16(IDS_CONTEXTUAL_SEARCH_HEADER));
strings_data.SetString(
« no previous file with comments | « chrome/browser/resources/contextual_search/promo.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698