Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 597553002: [chromium] Pass SkBitmap by reference in WebNinePatchLayer::setBitmap and refactor (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
Reviewers:
jamesr, vivekg
CC:
cc-bugs_chromium.org, chromium-reviews, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromium] Pass SkBitmap by reference in WebNinePatchLayer::setBitmap and refactor Although passing SkBitmap by value doesn't copy the underlying pixels, it indeed involves memcpy (~64 bytes to be precise) to replicate the settings from the other bitmap in the copy constructor. This overhead, albeit minor, can be avoided by passing SkBitmap as reference. R=jamesr@chromium.org Committed: https://crrev.com/f814f45c209ebc36f28251d8de602c099a54262e Cr-Commit-Position: refs/heads/master@{#296330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M cc/blink/web_nine_patch_layer_impl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/blink/web_nine_patch_layer_impl.cc View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vivekg
PTAL, thank you! Blink side changes here: https://codereview.chromium.org/594193002
6 years, 3 months ago (2014-09-23 14:46:37 UTC) #1
jamesr
lgtm
6 years, 3 months ago (2014-09-23 23:33:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597553002/1
6 years, 3 months ago (2014-09-24 00:26:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 94c31015dce1f3febd9ef2b44d082818f155ee03
6 years, 3 months ago (2014-09-24 02:10:23 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 02:11:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f814f45c209ebc36f28251d8de602c099a54262e
Cr-Commit-Position: refs/heads/master@{#296330}

Powered by Google App Engine
This is Rietveld 408576698