[blink] Pass SkBitmap by reference in WebNinePatchLayer::setBitmap and refactor

[blink] Pass SkBitmap by reference in WebNinePatchLayer::setBitmap and refactor

Although passing SkBitmap by value doesn't copy the underlying pixels, it indeed
involves memcpy (~64 bytes to be precise) to replicate the settings from the
other bitmap in the copy constructor.

This overhead, albeit minor, can be avoided by passing SkBitmap as reference.

R=jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182559

[vivekg, 2014-09-23 14:48:19]

PTAL, thank you!

Chromium side changes here: https://codereview.chromium.org/597553002

[jamesr, 2014-09-23 23:34:00]

lgtm

[vivekg, 2014-09-24 04:59:02]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-24 04:59:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/594193002/1

[commit-bot: I haz the power, 2014-09-24 06:07:04]

Committed patchset #1 (id:1) as 182559

[Nico, 2015-07-23 20:07:32]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-07-23 20:07:32]

fwiw, it looks like all the ninepatch stuff in blink is dead code; I just
deleted it (https://codereview.chromium.org/1248413003). Was this not the case
when this CL was written?

[danakj, 2015-07-23 20:14:53]

On 2015/07/23 20:07:32, Nico (hiding) wrote:
> fwiw, it looks like all the ninepatch stuff in blink is dead code; I just
> deleted it (https://codereview.chromium.org/1248413003). Was this not the case
> when this CL was written?

Nine patch layer was added to enable overlay scrollbars in aura that aren't
solid color. But the project lost traction and didn't complete (yet?). So it
remained dead.

[Nico, 2015-07-23 20:25:51]

Ah, I see. If it's revived, maybe it could use the other existing ninepatch
layer :-)

On Thu, Jul 23, 2015 at 1:14 PM, <danakj@chromium.org> wrote:

> On 2015/07/23 20:07:32, Nico (hiding) wrote:
>
>> fwiw, it looks like all the ninepatch stuff in blink is dead code; I just
>> deleted it (https://codereview.chromium.org/1248413003). Was this not
>> the case
>> when this CL was written?
>>
>
> Nine patch layer was added to enable overlay scrollbars in aura that aren't
> solid color. But the project lost traction and didn't complete (yet?). So
> it
> remained dead.
>
> https://codereview.chromium.org/594193002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.