Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 597523003: Remove the legacy fullscreen video path in Android. (Closed)

Created:
6 years, 3 months ago by Ignacio Solla
Modified:
6 years, 2 months ago
Reviewers:
mkosiba (inactive), jam
CC:
chromium-reviews, jam, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org, benm (inactive), qinmin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the legacy fullscreen video path in Android. Remove the legacy fullscreen video path that was used before html5 video controls were introduced. The last user was the WebView, but this has been migrated to html5 controls now. Committed: https://crrev.com/62f3270dc28a7bccc7820ea9fb51f18fd4c74f6e Cr-Commit-Position: refs/heads/master@{#296935}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase against 606633002. #

Patch Set 3 : Set diffbase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase correctly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -417 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java View 4 chunks +10 lines, -32 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java View 4 chunks +0 lines, -32 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 2 chunks +2 lines, -7 lines 0 comments Download
M content/browser/android/content_video_view.cc View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 3 2 chunks +4 lines, -11 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java View 1 chunk +2 lines, -9 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/ContentVideoViewLegacy.java View 1 chunk +0 lines, -302 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ShellManager.java View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Ignacio Solla
mkosiba@chromium.org: Please review changes in android_webview/ jam@chromium.org: Please review changes in content/ and chrome/
6 years, 3 months ago (2014-09-23 14:24:49 UTC) #2
mkosiba (inactive)
lgtm https://codereview.chromium.org/597523003/diff/1/content/browser/android/content_video_view.cc File content/browser/android/content_video_view.cc (left): https://codereview.chromium.org/597523003/diff/1/content/browser/android/content_video_view.cc#oldcode274 content/browser/android/content_video_view.cc:274: "Playing video").Pass(); intentional? how does the fullscreen html5 ...
6 years, 2 months ago (2014-09-24 15:38:31 UTC) #3
Ignacio Solla
https://codereview.chromium.org/597523003/diff/1/content/browser/android/content_video_view.cc File content/browser/android/content_video_view.cc (left): https://codereview.chromium.org/597523003/diff/1/content/browser/android/content_video_view.cc#oldcode274 content/browser/android/content_video_view.cc:274: "Playing video").Pass(); On 2014/09/24 15:38:30, mkosiba wrote: > intentional? ...
6 years, 2 months ago (2014-09-25 09:36:16 UTC) #4
Ignacio Solla
Applying the patch fails because I assume that I need to land the base patch ...
6 years, 2 months ago (2014-09-25 12:44:15 UTC) #5
jam
lgtm
6 years, 2 months ago (2014-09-25 22:44:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597523003/60001
6 years, 2 months ago (2014-09-26 12:43:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/61185) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/18910) ios_rel_device ...
6 years, 2 months ago (2014-09-26 12:46:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597523003/80001
6 years, 2 months ago (2014-09-26 13:06:05 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001) as e81bc186691a2810a0eca99b607ad22fe7ddee69
6 years, 2 months ago (2014-09-26 14:20:49 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 14:21:27 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/62f3270dc28a7bccc7820ea9fb51f18fd4c74f6e
Cr-Commit-Position: refs/heads/master@{#296935}

Powered by Google App Engine
This is Rietveld 408576698