chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java - Issue 597523003: Remove the legacy fullscreen video path in Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

Issue 597523003: Remove the legacy fullscreen video path in Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase correctly Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java ('k') | content/browser/android/content_video_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

index 62bbbadaaba1bd80d3d799d7de78ff754f5b45b5..48627d2a34d793e954c8a15b96aba8ce87aff631 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

@@ -37,7 +37,6 @@ import org.chromium.content.browser.ActivityContentVideoViewClient;

import org.chromium.content.browser.BrowserStartupController;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.DeviceUtils;

-import org.chromium.content.common.ContentSwitches;

import org.chromium.printing.PrintManagerDelegateImpl;

import org.chromium.printing.PrintingController;

import org.chromium.sync.signin.AccountManagerHelper;

@@ -141,18 +140,14 @@ public class ChromeShellActivity extends Activity implements AppMenuPropertiesDe

public boolean onShowCustomView(View view) {

if (mTabManager == null) return false;

boolean success = super.onShowCustomView(view);

- if (!CommandLine.getInstance().hasSwitch(

- ContentSwitches.DISABLE_OVERLAY_FULLSCREEN_VIDEO_SUBTITLE)) {

- mTabManager.setOverlayVideoMode(true);

- }

+ mTabManager.setOverlayVideoMode(true);

return success;

}

@Override

public void onDestroyContentVideoView() {

super.onDestroyContentVideoView();

- if (mTabManager != null && !CommandLine.getInstance().hasSwitch(

- ContentSwitches.DISABLE_OVERLAY_FULLSCREEN_VIDEO_SUBTITLE)) {

+ if (mTabManager != null) {

mTabManager.setOverlayVideoMode(false);

}