Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 597503003: Removed superfluous deopt for ROR on ia32. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 3 months ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Removed superfluous deopt for ROR on ia32. We only synthesize a ROR when we have an expression with a toplevel '|', which returns a signed value by definition, so deopting on negative values is not needed. ia32 was the only platform where this was done, all other didn't have the check. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
6 years, 3 months ago (2014-09-23 07:47:51 UTC) #2
ulan
lgtm
6 years, 3 months ago (2014-09-23 07:48:17 UTC) #3
Sven Panne
6 years, 3 months ago (2014-09-23 08:06:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24133 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698