Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 597503003: Removed superfluous deopt for ROR on ia32. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1598 matching lines...) Expand 10 before | Expand all | Expand 10 after
1609 LOperand* left = instr->left(); 1609 LOperand* left = instr->left();
1610 LOperand* right = instr->right(); 1610 LOperand* right = instr->right();
1611 DCHECK(left->Equals(instr->result())); 1611 DCHECK(left->Equals(instr->result()));
1612 DCHECK(left->IsRegister()); 1612 DCHECK(left->IsRegister());
1613 if (right->IsRegister()) { 1613 if (right->IsRegister()) {
1614 DCHECK(ToRegister(right).is(ecx)); 1614 DCHECK(ToRegister(right).is(ecx));
1615 1615
1616 switch (instr->op()) { 1616 switch (instr->op()) {
1617 case Token::ROR: 1617 case Token::ROR:
1618 __ ror_cl(ToRegister(left)); 1618 __ ror_cl(ToRegister(left));
1619 if (instr->can_deopt()) {
1620 __ test(ToRegister(left), ToRegister(left));
1621 DeoptimizeIf(sign, instr);
1622 }
1623 break; 1619 break;
1624 case Token::SAR: 1620 case Token::SAR:
1625 __ sar_cl(ToRegister(left)); 1621 __ sar_cl(ToRegister(left));
1626 break; 1622 break;
1627 case Token::SHR: 1623 case Token::SHR:
1628 __ shr_cl(ToRegister(left)); 1624 __ shr_cl(ToRegister(left));
1629 if (instr->can_deopt()) { 1625 if (instr->can_deopt()) {
1630 __ test(ToRegister(left), ToRegister(left)); 1626 __ test(ToRegister(left), ToRegister(left));
1631 DeoptimizeIf(sign, instr); 1627 DeoptimizeIf(sign, instr);
1632 } 1628 }
(...skipping 4057 matching lines...) Expand 10 before | Expand all | Expand 10 after
5690 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5686 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5691 RecordSafepoint(Safepoint::kNoLazyDeopt); 5687 RecordSafepoint(Safepoint::kNoLazyDeopt);
5692 } 5688 }
5693 5689
5694 5690
5695 #undef __ 5691 #undef __
5696 5692
5697 } } // namespace v8::internal 5693 } } // namespace v8::internal
5698 5694
5699 #endif // V8_TARGET_ARCH_IA32 5695 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698