Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 597413003: Introduce an "ExtensionWantsToAct" method (Closed)

Created:
6 years, 2 months ago by Devlin
Modified:
6 years, 2 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Introduce an "ExtensionWantsToAct" method Add an ExtensionWantsToAct() method on ExtensionActionAPI. Even though we're not quite sure what we want the UI to look like for an extension desiring to act, we can start a little bit of the plumbing now. For instance, exposing a method that allows a caller to check if an extension wants to act on a given page. BUG=417441 Committed: https://crrev.com/699ca6ff2ee26ba1fbac5532c75d25175dcf6884 Cr-Commit-Position: refs/heads/master@{#297309}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Latest master for CQ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -18 lines) Patch
M chrome/browser/extensions/active_script_controller.h View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/active_script_controller.cc View 7 chunks +29 lines, -15 lines 0 comments Download
M chrome/browser/extensions/active_script_controller_unittest.cc View 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 2 chunks +21 lines, -3 lines 0 comments Download
M chrome/browser/extensions/location_bar_controller_unittest.cc View 1 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Devlin
6 years, 2 months ago (2014-09-26 00:22:06 UTC) #3
Finnur
LGTM, with one small question addressed. https://codereview.chromium.org/597413003/diff/20001/chrome/browser/extensions/location_bar_controller_unittest.cc File chrome/browser/extensions/location_bar_controller_unittest.cc (right): https://codereview.chromium.org/597413003/diff/20001/chrome/browser/extensions/location_bar_controller_unittest.cc#newcode166 chrome/browser/extensions/location_bar_controller_unittest.cc:166: extension_action_api->ExtensionWantsToRun(extension, web_contents()); EXPECT_FALSE?
6 years, 2 months ago (2014-09-26 09:53:34 UTC) #4
Devlin
https://codereview.chromium.org/597413003/diff/20001/chrome/browser/extensions/location_bar_controller_unittest.cc File chrome/browser/extensions/location_bar_controller_unittest.cc (right): https://codereview.chromium.org/597413003/diff/20001/chrome/browser/extensions/location_bar_controller_unittest.cc#newcode166 chrome/browser/extensions/location_bar_controller_unittest.cc:166: extension_action_api->ExtensionWantsToRun(extension, web_contents()); On 2014/09/26 09:53:33, Finnur wrote: > EXPECT_FALSE? ...
6 years, 2 months ago (2014-09-29 22:56:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597413003/60001
6 years, 2 months ago (2014-09-29 22:57:48 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001) as 0e9642c12f453165649ad8db8c24d6374643f33f
6 years, 2 months ago (2014-09-30 00:00:05 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 00:01:01 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/699ca6ff2ee26ba1fbac5532c75d25175dcf6884
Cr-Commit-Position: refs/heads/master@{#297309}

Powered by Google App Engine
This is Rietveld 408576698