Introduce an "ExtensionWantsToAct" method

chrome/browser/extensions/location_bar_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/extensions/active_script_controller.h"
+#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/location_bar_controller.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/crx_file/id_util.h"
@@ skipping 131 matching lines @@
 TEST_F(LocationBarControllerUnitTest, NavigationClearsState) {
   const Extension* extension = AddExtension(true, "page_actions");
 
   NavigateAndCommit(GURL("http://www.google.com"));
 
   ExtensionAction& page_action =
       *ExtensionActionManager::Get(profile())->GetPageAction(*extension);
   page_action.SetTitle(tab_id(), "Goodbye");
   page_action.SetPopupUrl(tab_id(), extension->GetResourceURL("popup.html"));
 
+  ExtensionActionAPI* extension_action_api =
+      ExtensionActionAPI::Get(profile());
+  // By default, extensions shouldn't want to act on a page.
+  extension_action_api->ExtensionWantsToRun(extension, web_contents());

[Finnur, 2014/09/26 09:53:33]

EXPECT_FALSE?

[Devlin, 2014/09/29 22:56:51]

Done.

+  // Showing the page action should indicate that an extension *does* want to
+  // run on the page.
+  page_action.SetIsVisible(tab_id(), true);
+  EXPECT_TRUE(extension_action_api->ExtensionWantsToRun(extension,
+                                                        web_contents()));
+
   EXPECT_EQ("Goodbye", page_action.GetTitle(tab_id()));
   EXPECT_EQ(extension->GetResourceURL("popup.html"),
             page_action.GetPopupUrl(tab_id()));
 
   // Within-page navigation should keep the settings.
   NavigateAndCommit(GURL("http://www.google.com/#hash"));
 
   EXPECT_EQ("Goodbye", page_action.GetTitle(tab_id()));
   EXPECT_EQ(extension->GetResourceURL("popup.html"),
             page_action.GetPopupUrl(tab_id()));
+  EXPECT_TRUE(extension_action_api->ExtensionWantsToRun(extension,
+                                                        web_contents()));
 
   // Should discard the settings, and go back to the defaults.
   NavigateAndCommit(GURL("http://www.yahoo.com"));
 
   EXPECT_EQ("Hello", page_action.GetTitle(tab_id()));
   EXPECT_EQ(GURL(), page_action.GetPopupUrl(tab_id()));
+  EXPECT_FALSE(extension_action_api->ExtensionWantsToRun(extension,
+                                                         web_contents()));
 }
 
 }  // namespace
 }  // namespace extensions