Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 597383002: Suppress two WebGL conformance failures on Mac 10.9 with Intel HD 3000 GPU. (Closed)

Created:
6 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
dtu, bajones, tonyg
CC:
chromium-reviews, darin-cc_chromium.org, jam, Jamie Madill, piman+watch_chromium.org, telemetry+watch_chromium.org, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Suppress two WebGL conformance failures on Mac 10.9 with Intel HD 3000 GPU. Required exposing new Mac versions to Telemetry's test expectations. Added unit test. BUG=417415 Committed: https://crrev.com/e9b529eed5b782cc44ecfe85d23346bcce12d9fa Cr-Commit-Position: refs/heads/master@{#296634}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 9 (2 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
6 years, 2 months ago (2014-09-24 20:34:59 UTC) #2
bajones
lgtm
6 years, 2 months ago (2014-09-24 20:50:30 UTC) #3
tonyg
lgtm https://codereview.chromium.org/597383002/diff/1/tools/telemetry/telemetry/page/test_expectations.py File tools/telemetry/telemetry/page/test_expectations.py (right): https://codereview.chromium.org/597383002/diff/1/tools/telemetry/telemetry/page/test_expectations.py#newcode9 tools/telemetry/telemetry/page/test_expectations.py:9: 'mavericks', 'yosemite', 'linux', 'chromeos', 'android'] Fix lgtm for ...
6 years, 2 months ago (2014-09-24 21:29:34 UTC) #4
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/597383002/diff/1/tools/telemetry/telemetry/page/test_expectations.py File tools/telemetry/telemetry/page/test_expectations.py (right): https://codereview.chromium.org/597383002/diff/1/tools/telemetry/telemetry/page/test_expectations.py#newcode9 tools/telemetry/telemetry/page/test_expectations.py:9: 'mavericks', 'yosemite', 'linux', 'chromeos', 'android'] On 2014/09/24 21:29:34, tonyg ...
6 years, 2 months ago (2014-09-24 21:39:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597383002/1
6 years, 2 months ago (2014-09-24 21:39:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as e13f4b0fc9711faf8e247b0248328da806643e3d
6 years, 2 months ago (2014-09-25 03:21:49 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 03:22:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9b529eed5b782cc44ecfe85d23346bcce12d9fa
Cr-Commit-Position: refs/heads/master@{#296634}

Powered by Google App Engine
This is Rietveld 408576698