Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: tools/telemetry/telemetry/page/test_expectations_unittest.py

Issue 597383002: Suppress two WebGL conformance failures on Mac 10.9 with Intel HD 3000 GPU. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/test_expectations_unittest.py
diff --git a/tools/telemetry/telemetry/page/test_expectations_unittest.py b/tools/telemetry/telemetry/page/test_expectations_unittest.py
index fa77f7a54b522e2db9ba2f80fac78c41fb27f629..2165145204384195abcebc753ff222c0a0da8848 100644
--- a/tools/telemetry/telemetry/page/test_expectations_unittest.py
+++ b/tools/telemetry/telemetry/page/test_expectations_unittest.py
@@ -59,6 +59,9 @@ class SampleTestExpectations(test_expectations.TestExpectations):
self.Fail('page9.html', ['imagination'])
self.Fail('page10.html', [('imagination', 'PowerVR SGX 554')])
self.Fail('Pages.page_11')
+ self.Fail('page12.html', ['mountainlion'])
+ self.Fail('page13.html', ['mavericks'])
+ self.Fail('page14.html', ['yosemite'])
class TestExpectationsTest(unittest.TestCase):
def setUp(self):
@@ -189,3 +192,30 @@ class TestExpectationsTest(unittest.TestCase):
page = page_module.Page('http://test.com/page11.html', ps,
name='Pages.page_11')
self.assertExpectationEquals('fail', page)
+
+ # Verify version-specific Mac expectations.
+ def testMacVersionExpectations(self):
+ ps = page_set.PageSet()
+ page = page_module.Page('http://test.com/page12.html', ps)
+ self.assertExpectationEquals('fail', page,
+ StubPlatform('mac', 'mountainlion'))
+ self.assertExpectationEquals('pass', page,
+ StubPlatform('mac', 'mavericks'))
+ self.assertExpectationEquals('pass', page,
+ StubPlatform('mac', 'yosemite'))
+ ps = page_set.PageSet()
+ page = page_module.Page('http://test.com/page13.html', ps)
+ self.assertExpectationEquals('pass', page,
+ StubPlatform('mac', 'mountainlion'))
+ self.assertExpectationEquals('fail', page,
+ StubPlatform('mac', 'mavericks'))
+ self.assertExpectationEquals('pass', page,
+ StubPlatform('mac', 'yosemite'))
+ ps = page_set.PageSet()
+ page = page_module.Page('http://test.com/page14.html', ps)
+ self.assertExpectationEquals('pass', page,
+ StubPlatform('mac', 'mountainlion'))
+ self.assertExpectationEquals('pass', page,
+ StubPlatform('mac', 'mavericks'))
+ self.assertExpectationEquals('fail', page,
+ StubPlatform('mac', 'yosemite'))

Powered by Google App Engine
This is Rietveld 408576698