Issue 597103003: ArrayConcat regression recover after r20312 (appeared on dromaeo benchmarks).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 597103003: ArrayConcat regression recover after r20312 (appeared on dromaeo benchmarks). (Closed)

Created:
6 years, 3 months ago by Igor Sheludko

Modified:
6 years, 2 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

ArrayConcat regression recover after r20312 (appeared on dromaeo benchmarks). BUG=chromium:358561 LOG=N R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24269

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -62 lines)			Patch
M	src/builtins.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/elements.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/elements.cc	View	12 chunks	+70 lines, -56 lines	0 comments	Download

Total messages: 5 (2 generated)

Igor Sheludko

PTAL. I had to un-handlify the ElementsAccessor::CopyElements() to recover from regression.

6 years, 3 months ago (2014-09-24 14:28:37 UTC) #3

Yang

On 2014/09/24 14:28:37, Igor Sheludko wrote: > PTAL. I had to un-handlify the ElementsAccessor::CopyElements() to ...

6 years, 2 months ago (2014-09-25 09:51:22 UTC) #4

Igor Sheludko

6 years, 2 months ago (2014-09-29 08:22:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as 24269 (presubmit successful).