Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: src/elements.h

Issue 597103003: ArrayConcat regression recover after r20312 (appeared on dromaeo benchmarks). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/elements.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index d0bddf982d7934cf7a18e08ed08e419a4e136595..f4de4bb010d560a695a3db9aa6576e95f283fe74 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -146,9 +146,10 @@ class ElementsAccessor {
uint32_t destination_start,
int copy_size) = 0;
- // TODO(ishell): Keeping |source_holder| parameter in a non-handlified form
- // helps avoiding ArrayConcat() builtin performance degradation.
- // Revisit this later.
+ // NOTE: this method violates the handlified function signature convention:
+ // raw pointer parameter |source_holder| in the function that allocates.
+ // This is done intentionally to avoid ArrayConcat() builtin performance
+ // degradation.
virtual void CopyElements(
JSObject* source_holder,
uint32_t source_start,
« no previous file with comments | « src/builtins.cc ('k') | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698