Issue 597043002: Fix GN Mac component build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 597043002: Fix GN Mac component build. (Closed)

Created:
6 years, 3 months ago by Robert Sesek

Modified:
6 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix google_toolbox_for_mac GN Mac component BUILD.gn file. R=brettw@chromium.org Committed: https://crrev.com/ffb8c67d5ddc14c31d03b09a32ebf01df2e4f636 Cr-Commit-Position: refs/heads/master@{#296476}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	build/secondary/third_party/google_toolbox_for_mac/BUILD.gn	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597043002/20001

6 years, 3 months ago (2014-09-24 17:59:33 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 037219cf437cf4ddc9aa6b71504edb7e448a7c2a

6 years, 3 months ago (2014-09-24 18:46:29 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-24 18:47:31 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/ffb8c67d5ddc14c31d03b09a32ebf01df2e4f636
Cr-Commit-Position: refs/heads/master@{#296476}