Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2910)

Unified Diff: build/secondary/third_party/google_toolbox_for_mac/BUILD.gn

Issue 597043002: Fix GN Mac component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/third_party/google_toolbox_for_mac/BUILD.gn
diff --git a/build/secondary/third_party/google_toolbox_for_mac/BUILD.gn b/build/secondary/third_party/google_toolbox_for_mac/BUILD.gn
index 4d6fa0e0f4ca4ef0d96304b42e26446988920342..1977a06aa41333d7d0db022975f87c501b9fa14c 100644
--- a/build/secondary/third_party/google_toolbox_for_mac/BUILD.gn
+++ b/build/secondary/third_party/google_toolbox_for_mac/BUILD.gn
@@ -172,11 +172,11 @@ component("google_toolbox_for_mac") {
]
libs = [
- "AddressBook",
- "AppKit",
- "Carbon",
- "Cocoa",
- "QuartzCore",
+ "AddressBook.framework",
+ "AppKit.framework",
+ "Carbon.framework",
+ "Cocoa.framework",
+ "QuartzCore.framework",
]
} else { # is_ios
sources += [
@@ -198,6 +198,6 @@ component("google_toolbox_for_mac") {
# build). Only do this in a component build, so that the shipping
# chrome binary doesn't end up with unnecessarily exported
# symbols.
- config -= [ "//build/config/gcc:symbol_visibility_hidden" ]
+ configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698