Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 59693008: Give mojo_shell a TransportSecurityPersister (Closed)

Created:
7 years, 1 month ago by Aaron Boodman
Modified:
7 years, 1 month ago
Reviewers:
Lei Zhang, akalin
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Give mojo_shell a TransportSecurityPersister. This required moving TransportSecurityPersister into net. BUG=310293 R=akalin@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234667

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add TransportSecurityPersister to mojo_shell #

Patch Set 4 : sprinkle some NET_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -674 lines) Patch
D chrome/browser/net/transport_security_persister.h View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/browser/net/transport_security_persister.cc View 1 chunk +0 lines, -310 lines 0 comments Download
D chrome/browser/net/transport_security_persister_unittest.cc View 1 chunk +0 lines, -202 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/url_request_context_getter.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/shell/url_request_context_getter.cc View 1 2 2 chunks +18 lines, -1 line 0 comments Download
A + net/http/transport_security_persister.h View 1 2 5 chunks +15 lines, -10 lines 0 comments Download
A + net/http/transport_security_persister.cc View 3 chunks +6 lines, -1 line 0 comments Download
A + net/http/transport_security_persister_unittest.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M net/http/transport_security_state.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Aaron Boodman
7 years, 1 month ago (2013-11-11 20:56:09 UTC) #1
akalin
This used to live in net/ but was moved into c/b/net. Lei, do you remember ...
7 years, 1 month ago (2013-11-11 21:27:31 UTC) #2
Lei Zhang
On 2013/11/11 21:27:31, akalin wrote: > This used to live in net/ but was moved ...
7 years, 1 month ago (2013-11-11 21:42:41 UTC) #3
Aaron Boodman
There used to be some minor dependencies on content. I refactored those in https://codereview.chromium.org/57993004.
7 years, 1 month ago (2013-11-11 21:59:07 UTC) #4
akalin
lgtm
7 years, 1 month ago (2013-11-11 23:03:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/59693008/60001
7 years, 1 month ago (2013-11-11 23:54:35 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=35593
7 years, 1 month ago (2013-11-12 00:51:51 UTC) #7
Lei Zhang
chrome/ lgtm
7 years, 1 month ago (2013-11-12 01:28:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/59693008/60001
7 years, 1 month ago (2013-11-12 01:43:03 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-12 02:55:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/59693008/340001
7 years, 1 month ago (2013-11-12 21:05:53 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-12 22:05:50 UTC) #12
Aaron Boodman
7 years, 1 month ago (2013-11-13 00:09:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 manually as r234667 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698