Remove content dependency from TransportSecurityPersister.

Remove content dependency from TransportSecurityPersister.

This is in preparation to move the file to net/ssl so that it can be
used by mojo.

BUG=310293
R=ajwong@chromium.org, battre@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233975

[Aaron Boodman, 2013-11-04 21:23:36]

+abarth fyi

[battre, 2013-11-05 11:54:36]

LGTM with comment

https://codereview.chromium.org/57993004/diff/20001/chrome/browser/net/transp...
File chrome/browser/net/transport_security_persister.h (right):

https://codereview.chromium.org/57993004/diff/20001/chrome/browser/net/transp...
chrome/browser/net/transport_security_persister.h:49: // Must be created, used
and destroyed only on the IO thread.
Here you talk about IO thread while this gets somewhat lost in the rest. I think
it would be good to explain the threading of this class w.r.t. the two
SequencedTaskRunners.

https://codereview.chromium.org/57993004/diff/20001/chrome/browser/net/transp...
chrome/browser/net/transport_security_persister.h:120:
scoped_refptr<base::SequencedTaskRunner> background_runner_;
Add comments that foreground is IO thread and background is file thread? Maybe
even rename them accordingly?

[Aaron Boodman, 2013-11-06 21:57:06]

https://codereview.chromium.org/57993004/diff/20001/chrome/browser/net/transp...
File chrome/browser/net/transport_security_persister.h (right):

https://codereview.chromium.org/57993004/diff/20001/chrome/browser/net/transp...
chrome/browser/net/transport_security_persister.h:49: // Must be created, used
and destroyed only on the IO thread.
On 2013/11/05 11:54:36, battre wrote:
> Here you talk about IO thread while this gets somewhat lost in the rest. I
think
> it would be good to explain the threading of this class w.r.t. the two
> SequencedTaskRunners.

Done.

https://codereview.chromium.org/57993004/diff/20001/chrome/browser/net/transp...
chrome/browser/net/transport_security_persister.h:120:
scoped_refptr<base::SequencedTaskRunner> background_runner_;
On 2013/11/05 11:54:36, battre wrote:
> Add comments that foreground is IO thread and background is file thread? Maybe
> even rename them accordingly?

In Mojo, this class isn't necessarily created on the IO thread. I'd rather not
couple the implementation to its usage in Chrome.

[commit-bot: I haz the power, 2013-11-06 22:04:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/57993004/70001

[commit-bot: I haz the power, 2013-11-06 23:06:31]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Aaron Boodman, 2013-11-06 23:15:02]

+ajwong for profiles/

[awong, 2013-11-06 23:19:30]

ProfileIOData: LGTM

[commit-bot: I haz the power, 2013-11-06 23:46:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/57993004/70001

[commit-bot: I haz the power, 2013-11-07 04:29:10]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-07 06:12:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/57993004/70001

[commit-bot: I haz the power, 2013-11-07 06:22:41]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Aaron Boodman, 2013-11-08 20:39:15]

Committed patchset #3 manually as r233975 (presubmit successful).