Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 596923003: Fix memory leakage in VideoSourceHandlerTest.OpenWithoutClose (Closed)

Created:
6 years, 2 months ago by haraken
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix memory leakage in VideoSourceHandlerTest.OpenWithoutClose This CL is needed for landing https://codereview.chromium.org/552653005. https://codereview.chromium.org/552653005 moves MediaStream-related objects to Oilpan's heap, and the objects are not collected until a next GC is triggered. Thus some of the Chromium-side tests need to clear those objects and explicitly trigger a GC in order to make sure that all objects are collected by the end of each test. Otherwise LSan complains the leakage. I've already landed a similar fix before: https://codereview.chromium.org/566793002/ I think this CL is a final fix for the memory leakage. BUG=416466 Committed: https://crrev.com/d9d5b48cddd6e7327a863cdbaac7cc365df4568c Cr-Commit-Position: refs/heads/master@{#297145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/media/video_source_handler_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
haraken
tommi or perkj: Would you take a look at this change? I think this is ...
6 years, 2 months ago (2014-09-29 01:54:08 UTC) #2
perkj_chrome
lgtm lgtm
6 years, 2 months ago (2014-09-29 06:23:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596923003/1
6 years, 2 months ago (2014-09-29 06:24:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c1456aaff5c5241280726f68ff7d5fbb7c64cbae
6 years, 2 months ago (2014-09-29 06:59:56 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 07:00:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9d5b48cddd6e7327a863cdbaac7cc365df4568c
Cr-Commit-Position: refs/heads/master@{#297145}

Powered by Google App Engine
This is Rietveld 408576698