Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 596843002: Skipping AEC tests when there is no audio device. (Closed)

Created:
6 years, 3 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Skipping AEC tests when there is no audio device. BUG=415372 Committed: https://crrev.com/076f82b443f52def6a2b8ce5d65491a8e79cc6d8 Cr-Commit-Position: refs/heads/master@{#296753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/browser/media/webrtc_aecdump_browsertest.cc View 4 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
phoglund_chromium
6 years, 3 months ago (2014-09-23 16:15:10 UTC) #2
phoglund_chromium
ping xians
6 years, 2 months ago (2014-09-25 18:06:31 UTC) #3
no longer working on chromium
On 2014/09/25 18:06:31, phoglund wrote: > ping xians lgtm. Sorry, I missed the email.
6 years, 2 months ago (2014-09-25 18:12:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596843002/1
6 years, 2 months ago (2014-09-25 18:13:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1af3f3642be51ae00c18b26bc7770d393dcd70d6
6 years, 2 months ago (2014-09-25 19:05:01 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 19:05:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/076f82b443f52def6a2b8ce5d65491a8e79cc6d8
Cr-Commit-Position: refs/heads/master@{#296753}

Powered by Google App Engine
This is Rietveld 408576698