Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: content/browser/media/webrtc_aecdump_browsertest.cc

Issue 596843002: Skipping AEC tests when there is no audio device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/webrtc_aecdump_browsertest.cc
diff --git a/content/browser/media/webrtc_aecdump_browsertest.cc b/content/browser/media/webrtc_aecdump_browsertest.cc
index b23900713e90da8aec558246700ebd807e882fbf..d5efad0883efad2571f5c6e18646a777036b34e0 100644
--- a/content/browser/media/webrtc_aecdump_browsertest.cc
+++ b/content/browser/media/webrtc_aecdump_browsertest.cc
@@ -11,6 +11,7 @@
#include "content/public/test/content_browser_test_utils.h"
#include "content/shell/browser/shell.h"
#include "content/test/webrtc_content_browsertest_base.h"
+#include "media/audio/audio_manager.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
namespace {
@@ -63,6 +64,11 @@ class WebRtcAecDumpBrowserTest : public WebRtcContentBrowserTest {
// the dialog callback FileSelected() is invoked directly. In fact, there's
// never a webrtc-internals page opened at all since that's not needed.
IN_PROC_BROWSER_TEST_F(WebRtcAecDumpBrowserTest, MAYBE_CallWithAecDump) {
+ if (!media::AudioManager::Get()->HasAudioOutputDevices()) {
+ LOG(INFO) << "Missing output devices: skipping test...";
+ return;
+ }
+
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
// We must navigate somewhere first so that the render process is created.
@@ -116,6 +122,11 @@ IN_PROC_BROWSER_TEST_F(WebRtcAecDumpBrowserTest, MAYBE_CallWithAecDump) {
// be created, but should be empty.
IN_PROC_BROWSER_TEST_F(WebRtcAecDumpBrowserTest,
MAYBE_CallWithAecDumpEnabledThenDisabled) {
+ if (!media::AudioManager::Get()->HasAudioOutputDevices()) {
+ LOG(INFO) << "Missing output devices: skipping test...";
+ return;
+ }
+
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
// We must navigate somewhere first so that the render process is created.
@@ -157,6 +168,11 @@ IN_PROC_BROWSER_TEST_F(WebRtcAecDumpBrowserTest,
#endif
IN_PROC_BROWSER_TEST_F(WebRtcAecDumpBrowserTest, MAYBE_TwoCallsWithAecDump) {
+ if (!media::AudioManager::Get()->HasAudioOutputDevices()) {
+ LOG(INFO) << "Missing output devices: skipping test...";
+ return;
+ }
+
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
// We must navigate somewhere first so that the render process is created.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698