content: Fix layering violation in GpuMemoryBufferImplOzoneNativeBuffer.

content: Fix layering violation in GpuMemoryBufferImplOzoneNativeBuffer.

GpuMemoryBufferImplOzoneNativeBuffer should not be calling
platform specific GpuMemoryBufferImpl::CreateFromHandle.

BUG=416873
TBR=piman

Committed: https://crrev.com/325baf9043362c7a6f2e19929264d86c835eec9d
Cr-Commit-Position: refs/heads/master@{#296316}

[reveman, 2014-09-23 16:15:17]

reveman@chromium.org changed reviewers:
+ alexst@chromium.org

[reveman, 2014-09-23 16:15:17]

https://codereview.chromium.org/596833002/diff/1/content/common/gpu/client/gp...
File content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc
(right):

https://codereview.chromium.org/596833002/diff/1/content/common/gpu/client/gp...
content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc:17: void
GpuMemoryBufferCreated(
I renamed these functions to make things a bit more consistent.

https://codereview.chromium.org/596833002/diff/1/content/common/gpu/client/gp...
File content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h
(right):

https://codereview.chromium.org/596833002/diff/1/content/common/gpu/client/gp...
content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h:27:
static void AllocateOzoneNativeBufferForChildProcess(
I think ChildProcess is more appropriate as this refer to the type of allocation
rather than the client id used. This will make it cleaner to implement proper
deletion of buffers.

[alexst (slow to review), 2014-09-23 16:43:56]

lgtm after the typo fix.

https://codereview.chromium.org/596833002/diff/1/content/common/gpu/client/gp...
File content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc
(right):

https://codereview.chromium.org/596833002/diff/1/content/common/gpu/client/gp...
content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc:26: if
(buffer->InitializeFromHandle(handle)) {
I think you meant

if (!buffer->...)

[reveman, 2014-09-23 18:31:47]

https://codereview.chromium.org/596833002/diff/1/content/common/gpu/client/gp...
File content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc
(right):

https://codereview.chromium.org/596833002/diff/1/content/common/gpu/client/gp...
content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc:26: if
(buffer->InitializeFromHandle(handle)) {
On 2014/09/23 16:43:56, alexst wrote:
> I think you meant
> 
> if (!buffer->...)

Done.

[reveman, 2014-09-23 18:32:08]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-09-23 20:31:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596833002/20001

[commit-bot: I haz the power, 2014-09-23 20:53:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 20:53:53]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[reveman, 2014-09-23 21:04:59]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:06:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596833002/40001

[commit-bot: I haz the power, 2014-09-23 21:21:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:21:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[reveman, 2014-09-23 23:52:15]

reveman@chromium.org changed reviewers:
+ piman@chromium.org

[reveman, 2014-09-23 23:52:25]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-09-23 23:53:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596833002/40001

[commit-bot: I haz the power, 2014-09-24 00:30:43]

Committed patchset #3 (id:40001) as 029115c55e9ab34b0589860a983668e48a807fa3

[commit-bot: I haz the power, 2014-09-24 00:31:24]

Patchset 3 (id:??) landed as
https://crrev.com/325baf9043362c7a6f2e19929264d86c835eec9d
Cr-Commit-Position: refs/heads/master@{#296316}

[piman, 2014-09-24 00:34:46]

lgtm