content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h - Issue 596833002: content: Fix layering violation in GpuMemoryBufferImplOzoneNativeBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h

Issue 596833002: content: Fix layering violation in GpuMemoryBufferImplOzoneNativeBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix another typo Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/gpu_memory_buffer_impl_ozone.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h b/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h

index 283f44fd3fbbfc1ceee33532d161aca99c5891df..bcdc58b4b8edab0535123fc4f6cbde304a779f7b 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h

@@ -16,15 +16,17 @@ class GpuMemoryBufferImplOzoneNativeBuffer : public GpuMemoryBufferImpl {

unsigned internalformat);

virtual ~GpuMemoryBufferImplOzoneNativeBuffer();

+ // Create an ozone native buffer backed GPU memory buffer with |size| and

+ // |internalformat| for |usage| by current process using |client_id|.

static void Create(const gfx::Size& size,

unsigned internalformat,

unsigned usage,

int client_id,

const CreationCallback& callback);

- // Allocates an Ozone native buffer backed GPU memory buffer with |size| and

- static void AllocateOzoneNativeBufferForChildId(

+ // Allocate an ozone native buffer backed GPU memory buffer with |size| and

+ // |internalformat| for |usage| by a child process using |child_client_id|.

+ static void AllocateOzoneNativeBufferForChildProcess(

const gfx::Size& size,

unsigned internalformat,

unsigned usage,

@@ -44,10 +46,6 @@ class GpuMemoryBufferImplOzoneNativeBuffer : public GpuMemoryBufferImpl {

virtual gfx::GpuMemoryBufferHandle GetHandle() const OVERRIDE;

private:

- static void OnGpuMemoryBufferCreated(

- const AllocationCallback& callback,

- const gfx::GpuMemoryBufferHandle& handle);

gfx::GpuMemoryBufferId id_;

DISALLOW_COPY_AND_ASSIGN(GpuMemoryBufferImplOzoneNativeBuffer);