Add missing dependencies for Blink public/

Add missing dependencies for Blink public/

Some files in these gyp files include from Blink's public/, but
without the dependency the include paths aren't included, which
is blocking <https://codereview.chromium.org/65763002/>;.

BUG=none

[jamesr, 2013-11-10 01:05:13]

Hmm, common targets shouldn't link against blink. What include paths are
they missing? Maybe we can create a settings-only target.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[philipj_slow, 2013-11-10 14:38:23]

On 2013/11/10 01:05:13, jamesr wrote:
> Hmm, common targets shouldn't link against blink. What include paths are
> they missing? Maybe we can create a settings-only target.

I tried switching to blink_minimal, but that didn't work because it only
includes WebCString, WebString and WebCommon.

Are you saying that we should have a new target which does nothing except add
'<(DEPTH)/third_party/WebKit' to include_dirs?

[jamesr, 2013-11-12 02:33:51]

On 2013/11/10 14:38:23, philipj wrote:
> On 2013/11/10 01:05:13, jamesr wrote:
> > Hmm, common targets shouldn't link against blink. What include paths are
> > they missing? Maybe we can create a settings-only target.
> 
> I tried switching to blink_minimal, but that didn't work because it only
> includes WebCString, WebString and WebCommon.

What else are these using?  They can't link against anything else, given that
the common targets don't link against blink.


> Are you saying that we should have a new target which does nothing except add
> '<(DEPTH)/third_party/WebKit' to include_dirs?

and include dirs from dependencies, yes

[philipj_slow, 2013-11-12 08:17:37]

On 2013/11/12 02:33:51, jamesr wrote:
> On 2013/11/10 14:38:23, philipj wrote:
> > On 2013/11/10 01:05:13, jamesr wrote:
> > > Hmm, common targets shouldn't link against blink. What include paths are
> > > they missing? Maybe we can create a settings-only target.
> > 
> > I tried switching to blink_minimal, but that didn't work because it only
> > includes WebCString, WebString and WebCommon.
> 
> What else are these using?  They can't link against anything else, given that
> the common targets don't link against blink.

There's lots of other stuff, e.g. the first compile error was this:

In file included from ../../webkit/common/cursors/webcursor.h:9:0,
                 from ../../webkit/common/cursors/webcursor.cc:5:
../../third_party/WebKit/public/web/WebCursorInfo.h:31:43: fatal error:
public/platform/WebCursorInfo.h: No such file or directory

Linking doesn't matter when using these pure virtual interfaces, which is mostly
(only?) what's in public/platform.

> > Are you saying that we should have a new target which does nothing except
add
> > '<(DEPTH)/third_party/WebKit' to include_dirs?
> 
> and include dirs from dependencies, yes

I tried this: https://codereview.chromium.org/65763002/patch/400001/410001

Doesn't work, and I don't know why. I'm giving up on this now, as it doesn't
seem to be worth the effort. It would be interesting to know why the above
doesn't work, but not very important.

[jamesr, 2013-11-12 08:19:31]

Yeah, this doesn't look like a particularly fruitful avenue to explore.
Sorry.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.