Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 596793002: continue update even if user has deleted executable (Closed)

Created:
6 years, 3 months ago by danrubel
Modified:
6 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

continue update even if user has deleted executable BUG=dartbug.com/17018 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40592

Patch Set 1 #

Patch Set 2 : remove blank line #

Patch Set 3 : merge and check that executable exists before rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M editor/tools/plugins/com.google.dart.tools.update.core/src/com/google/dart/tools/update/core/internal/jobs/InstallUpdateAction.java View 1 2 3 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 3 months ago (2014-09-23 13:35:30 UTC) #2
scheglov
LGTM
6 years, 3 months ago (2014-09-23 13:51:56 UTC) #3
danrubel
6 years, 3 months ago (2014-09-23 14:28:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 40592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698