Issue 59663002: Switch the WebstoreDataFetcherDelegate::OnWebstoreResponseParseSuccess interface to scoped_ptr.

Issue 59663002: Switch the WebstoreDataFetcherDelegate::OnWebstoreResponseParseSuccess interface to scoped_ptr. (Closed)

Created:
7 years, 1 month ago by earthdok

Modified:
7 years, 1 month ago

Reviewers:
benwells, satorux1

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch the WebstoreDataFetcherDelegate::OnWebstoreResponseParseSuccess interface to scoped_ptr. Re-land of r232877 which was missing an include. Fixes memory leaks. BUG=313695 R=benwells@chromium.org, satorux@chromium.org TBR=benwells@chromium.org, satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233253

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -14 lines)			Patch
M	chrome/browser/chromeos/app_mode/kiosk_app_data.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/app_mode/kiosk_app_data.cc	View	1 chunk	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/webstore_data_fetcher.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/webstore_data_fetcher_delegate.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/webstore_standalone_installer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/webstore_standalone_installer.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

earthdok

previous review: https://codereview.chromium.org/51113014/

7 years, 1 month ago (2013-11-05 11:25:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/59663002/1

7 years, 1 month ago (2013-11-05 22:56:41 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...

7 years, 1 month ago (2013-11-06 01:47:33 UTC) #5

earthdok

7 years, 1 month ago (2013-11-06 10:26:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r233253 (presubmit successful).

Expand Messages | Collapse Messages