Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6418)

Unified Diff: chrome/browser/extensions/webstore_standalone_installer.cc

Issue 59663002: Switch the WebstoreDataFetcherDelegate::OnWebstoreResponseParseSuccess interface to scoped_ptr. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_standalone_installer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_standalone_installer.cc
diff --git a/chrome/browser/extensions/webstore_standalone_installer.cc b/chrome/browser/extensions/webstore_standalone_installer.cc
index 3100c9535417b64437d1b1a5fd2e62e41832fa10..9f13c3cc5cec2d5c44d4bbbb24af36f67584554e 100644
--- a/chrome/browser/extensions/webstore_standalone_installer.cc
+++ b/chrome/browser/extensions/webstore_standalone_installer.cc
@@ -88,7 +88,7 @@ void WebstoreStandaloneInstaller::OnWebstoreRequestFailure() {
}
void WebstoreStandaloneInstaller::OnWebstoreResponseParseSuccess(
- DictionaryValue* webstore_data) {
+ scoped_ptr<DictionaryValue> webstore_data) {
if (!CheckRequestorAlive()) {
CompleteInstall(std::string());
return;
@@ -153,7 +153,7 @@ void WebstoreStandaloneInstaller::OnWebstoreResponseParseSuccess(
}
// Assume ownership of webstore_data.
- webstore_data_.reset(webstore_data);
+ webstore_data_ = webstore_data.Pass();
scoped_refptr<WebstoreInstallHelper> helper =
new WebstoreInstallHelper(this,
« no previous file with comments | « chrome/browser/extensions/webstore_standalone_installer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698