Move paint code from RenderFlexibleBox to BlockPainter.

Move paint code from RenderFlexibleBox to BlockPainter.

BUG=412088
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182465

[chrishtr, 2014-09-22 23:00:26]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2014-09-22 23:07:48]

LGTM

https://codereview.chromium.org/596583002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderFlexibleBox.cpp (right):

https://codereview.chromium.org/596583002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderFlexibleBox.cpp:283: void
RenderFlexibleBox::paintChildren(PaintInfo& paintInfo, const LayoutPoint&
paintOffset)
For a future patch: I looked into this and we only have a few users of
paintChildren and they all paint through statics now. We can probably refactor
this so we never even leave BlockPainter::paintChildren.

[chrishtr, 2014-09-22 23:10:37]

https://codereview.chromium.org/596583002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderFlexibleBox.cpp (right):

https://codereview.chromium.org/596583002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderFlexibleBox.cpp:283: void
RenderFlexibleBox::paintChildren(PaintInfo& paintInfo, const LayoutPoint&
paintOffset)
On 2014/09/22 23:07:48, pdr wrote:
> For a future patch: I looked into this and we only have a few users of
> paintChildren and they all paint through statics now. We can probably refactor
> this so we never even leave BlockPainter::paintChildren.

Kewl.

[pdr., 2014-09-23 02:57:40]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-09-23 02:58:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596583002/1

[commit-bot: I haz the power, 2014-09-23 02:58:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 02:58:46]

Failed to apply patch for Source/core/paint/BlockPainter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/paint/BlockPainter.h
  Hunk #2 FAILED at 26.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/paint/BlockPainter.h.rej

Patch:       Source/core/paint/BlockPainter.h
Index: Source/core/paint/BlockPainter.h
diff --git a/Source/core/paint/BlockPainter.h b/Source/core/paint/BlockPainter.h
index
0364e7250e70013fc79280f04f9fef70d855615b..710f1a809e223ee50b3f882af8385b96b88aee81
100644
--- a/Source/core/paint/BlockPainter.h
+++ b/Source/core/paint/BlockPainter.h
@@ -11,6 +11,7 @@ namespace blink {
 
 struct PaintInfo;
 class LayoutPoint;
+class RenderFlexibleBox;
 
 class BlockPainter {
 public:
@@ -25,6 +26,7 @@ public:
     // (grid items, flex items) require this behavior as well, and this
function exists as a helper for them.
     // It is expected that the caller will call this function independent of
the value of paintInfo.phase.
     static void paintAsInlineBlock(RenderObject*, PaintInfo&, const
LayoutPoint&);
+    static void paintChildrenOfFlexibleBox(RenderFlexibleBox&, PaintInfo&,
const LayoutPoint& paintOffset);
 
 private:
     LayoutRect overflowRectForPaintRejection() const;

[chrishtr, 2014-09-23 03:35:34]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-09-23 03:36:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596583002/20001

[commit-bot: I haz the power, 2014-09-23 04:42:34]

Committed patchset #2 (id:20001) as 182465