Issue 596353002: Specify the path to the old setup.exe in the lpApplicationName parameter to CreateProcess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 596353002: Specify the path to the old setup.exe in the lpApplicationName parameter to CreateProcess. (Closed)

Created:
6 years, 3 months ago by grt (UTC plus 2)

Modified:
6 years, 3 months ago

Reviewers:
gab

CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@notreached

Project:
chromium

Visibility:
Public.

Specify the path to the old setup.exe in the lpApplicationName parameter to CreateProcess. This is a reland of http://crrev.com/3882aae7 since http://crrev.com/40d8624d should have fixed the problem leading to diff update failures. BUG=340387 TEST=N/A Committed: https://crrev.com/8b12f969b04be8c9a8a45931665844c9515f926b Cr-Commit-Position: refs/heads/master@{#296428}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/installer/mini_installer/mini_installer.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596353002/1

6 years, 3 months ago (2014-09-24 15:48:31 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 2ef5d6339f54ac28a194fd9e6d168e3493704b19

6 years, 3 months ago (2014-09-24 15:59:48 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-24 16:00:26 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8b12f969b04be8c9a8a45931665844c9515f926b
Cr-Commit-Position: refs/heads/master@{#296428}