Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6775)

Unified Diff: chrome/installer/mini_installer/mini_installer.cc

Issue 596353002: Specify the path to the old setup.exe in the lpApplicationName parameter to CreateProcess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notreached
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer/mini_installer.cc
diff --git a/chrome/installer/mini_installer/mini_installer.cc b/chrome/installer/mini_installer/mini_installer.cc
index da3cf91d5a6d030c98d4dab32979ddeba27c7770..e00569c7fad3d1da3206835dc2c8282ea2ee7329 100644
--- a/chrome/installer/mini_installer/mini_installer.cc
+++ b/chrome/installer/mini_installer/mini_installer.cc
@@ -405,10 +405,12 @@ bool UnpackBinaryResources(const Configuration& configuration, HMODULE module,
// If we found setup 'B7' resource, handle it.
if (setup_path->length() > 0) {
CommandString cmd_line;
+ PathString exe_path;
// Get the path to setup.exe first.
bool success = true;
- if (!GetSetupExePathFromRegistry(configuration, cmd_line.get(),
- cmd_line.capacity()) ||
+ if (!GetSetupExePathFromRegistry(configuration, exe_path.get(),
+ exe_path.capacity()) ||
+ !cmd_line.append(exe_path.get()) ||
!cmd_line.append(L" --") ||
!cmd_line.append(kCmdUpdateSetupExe) ||
!cmd_line.append(L"=\"") ||
@@ -429,7 +431,7 @@ bool UnpackBinaryResources(const Configuration& configuration, HMODULE module,
ProcessExitCode exit_code = SUCCESS_EXIT_CODE;
if (success &&
- (!RunProcessAndWait(NULL, cmd_line.get(), &exit_code) ||
+ (!RunProcessAndWait(exe_path.get(), cmd_line.get(), &exit_code) ||
exit_code != SUCCESS_EXIT_CODE)) {
success = false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698