Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 596153003: Remove implicit HANDLE conversions from components. (Closed)

Created:
6 years, 3 months ago by rvargas (doing something else)
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit HANDLE conversions from components. BUG=416722 R=jochen@chromium.org TBR=thestig@chromium.org Committed: https://crrev.com/c94f1fb74a18bf626546461426cb2630836467d0 Cr-Commit-Position: refs/heads/master@{#297312}

Patch Set 1 #

Patch Set 2 : Remove spurious file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M components/metrics/machine_id_provider_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl/common/nacl_debug_exception_handler_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
rvargas (doing something else)
6 years, 3 months ago (2014-09-24 22:57:03 UTC) #1
Mike West
Drive-by LGTM; explicit is better. You'll still need a real OWNER to stamp the CL, ...
6 years, 2 months ago (2014-09-26 11:39:07 UTC) #3
rvargas (doing something else)
Going to individual components owners to get things moving. jvoung@: nacl mpearson@: metrics vandebo@: storage ...
6 years, 2 months ago (2014-09-29 21:52:14 UTC) #5
rvargas (doing something else)
+gbillock - vandebo
6 years, 2 months ago (2014-09-29 21:53:26 UTC) #7
vandebo (ex-Chrome)
-gbillock +thestig
6 years, 2 months ago (2014-09-29 21:57:14 UTC) #9
Mark P
components/metrics/... lgtm
6 years, 2 months ago (2014-09-29 21:58:58 UTC) #10
jvoung (off chromium)
lgtm
6 years, 2 months ago (2014-09-29 22:13:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596153003/20001
6 years, 2 months ago (2014-09-29 23:36:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ab5807c0185f0510877c38909f43330af817f216
6 years, 2 months ago (2014-09-30 00:05:33 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c94f1fb74a18bf626546461426cb2630836467d0 Cr-Commit-Position: refs/heads/master@{#297312}
6 years, 2 months ago (2014-09-30 00:06:23 UTC) #15
Lei Zhang
6 years, 2 months ago (2014-10-06 19:13:40 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698