components/nacl/browser/nacl_process_host.cc - Issue 596153003: Remove implicit HANDLE conversions from components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_process_host.cc

Issue 596153003: Remove implicit HANDLE conversions from components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove spurious file Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/browser/nacl_process_host.cc

diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc

index b6345f0bd2be14867b3ea37555fedf6a2b4e7729..7cf381e549f484097f99511808af9e7053ff18d4 100644

--- a/components/nacl/browser/nacl_process_host.cc

+++ b/components/nacl/browser/nacl_process_host.cc

@@ -1189,7 +1189,8 @@ bool NaClProcessHost::AttachDebugExceptionHandler(const std::string& info,

// the 32-bit browser process to run the debug exception handler.

if (RunningOnWOW64()) {

return NaClBrokerService::GetInstance()->LaunchDebugExceptionHandler(

- weak_factory_.GetWeakPtr(), nacl_pid, process_handle, info);

+ weak_factory_.GetWeakPtr(), nacl_pid, process_handle.Get(),

+ info);

} else {

NaClStartDebugExceptionHandlerThread(

process_handle.Take(), info,