Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: base/files/file_path_unittest.cc

Issue 596103002: Fix more disabled MSVC warnings, base/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't assume char (un)signedness Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/file_path_unittest.cc
diff --git a/base/files/file_path_unittest.cc b/base/files/file_path_unittest.cc
index fa7627c2f9be81be7394771c2d6e99dd05df47be..8b6f3a8af1b58ad840dec16b5741258ec38bfa88 100644
--- a/base/files/file_path_unittest.cc
+++ b/base/files/file_path_unittest.cc
@@ -770,16 +770,16 @@ TEST_F(FilePathTest, Extension2) {
FilePath path(cases[i].input);
FilePath::StringType extension = path.Extension();
FilePath::StringType final_extension = path.FinalExtension();
- EXPECT_STREQ(cases[i].expected, extension.c_str()) << "i: " << i <<
- ", path: " << path.value();
- EXPECT_STREQ(cases[i].expected, final_extension.c_str()) << "i: " << i <<
- ", path: " << path.value();
+ EXPECT_STREQ(cases[i].expected, extension.c_str())
+ << "i: " << i << ", path: " << path.value();
+ EXPECT_STREQ(cases[i].expected, final_extension.c_str())
+ << "i: " << i << ", path: " << path.value();
}
for (unsigned int i = 0; i < arraysize(double_extension_cases); ++i) {
- FilePath path(cases[i].input);
+ FilePath path(double_extension_cases[i].input);
FilePath::StringType extension = path.Extension();
- EXPECT_STREQ(cases[i].expected, extension.c_str()) << "i: " << i <<
- ", path: " << path.value();
+ EXPECT_STREQ(double_extension_cases[i].expected, extension.c_str())
+ << "i: " << i << ", path: " << path.value();
}
}

Powered by Google App Engine
This is Rietveld 408576698