base/file_version_info_win.cc - Issue 596103002: Fix more disabled MSVC warnings, base/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/file_version_info_win.cc

Issue 596103002: Fix more disabled MSVC warnings, base/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't assume char (un)signedness Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/file_version_info_win.cc

diff --git a/base/file_version_info_win.cc b/base/file_version_info_win.cc

index 5f33d1470f11c152976b1e4ab6e7bf295dba9dbb..46b0581db97ff1fd41c621fce352af14527e56a0 100644

--- a/base/file_version_info_win.cc

+++ b/base/file_version_info_win.cc

@@ -14,7 +14,9 @@

using base::FilePath;

-FileVersionInfoWin::FileVersionInfoWin(void* data, int language, int code_page)

+FileVersionInfoWin::FileVersionInfoWin(void* data,

+ WORD language,

+ WORD code_page)

: language_(language), code_page_(code_page) {

base::ThreadRestrictions::AssertIOAllowed();

data_.reset((char*) data);