Add client type in chrome-proxy header for desktop.

Add client type in chrome-proxy header for desktop.

Make client an enum instead of string.

BUG=412982
Committed: https://crrev.com/d650ae28dae3a4c9d6073224d03705c0ff7a9fdf
Cr-Commit-Position: refs/heads/master@{#297885}

[Not at Google. Contact bengr, 2014-09-23 20:01:57]

kundaji@chromium.org changed reviewers:
+ bengr@chromium.org

[Not at Google. Contact bengr, 2014-09-23 20:02:15]

bengr:
  chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
 
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
 
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

[bengr, 2014-09-23 20:18:51]

https://codereview.chromium.org/596053003/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
(right):

https://codereview.chromium.org/596053003/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:44:
const char kClientQnx[] = "qnx";
Please add chromeos while you're at it.

https://codereview.chromium.org/596053003/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
(right):

https://codereview.chromium.org/596053003/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h:35:
extern const char kClientMac[];
While you're here, would you please change the constructor to take an enum
instead of a string for client? These strings are implementation details that
should not be exposed to the caller.

[Not at Google. Contact bengr, 2014-09-29 23:47:18]

https://codereview.chromium.org/596053003/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
(right):

https://codereview.chromium.org/596053003/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:44:
const char kClientQnx[] = "qnx";
On 2014/09/23 20:18:50, bengr1 wrote:
> Please add chromeos while you're at it.

Done.

https://codereview.chromium.org/596053003/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
(right):

https://codereview.chromium.org/596053003/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h:35:
extern const char kClientMac[];
On 2014/09/23 20:18:50, bengr1 wrote:
> While you're here, would you please change the constructor to take an enum
> instead of a string for client? These strings are implementation details that
> should not be exposed to the caller.

Done.

[bengr, 2014-10-02 17:36:07]

lgtm, but please address my nits.

https://codereview.chromium.org/596053003/diff/180001/components/data_reducti...
File
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
(right):

https://codereview.chromium.org/596053003/diff/180001/components/data_reducti...
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:64:
const Client client,
"const" isn't needed here.

https://codereview.chromium.org/596053003/diff/180001/components/data_reducti...
File
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler_unittest.cc
(right):

https://codereview.chromium.org/596053003/diff/180001/components/data_reducti...
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler_unittest.cc:96:
const Client client,
"const" isn't needed here.

[Not at Google. Contact bengr, 2014-10-02 17:38:19]

kundaji@chromium.org changed reviewers:
+ marq@chromium.org

[Not at Google. Contact bengr, 2014-10-02 17:38:39]

kundaji@chromium.org changed reviewers:
- marq@chromium.org

[Not at Google. Contact bengr, 2014-10-02 18:07:45]

https://codereview.chromium.org/596053003/diff/180001/components/data_reducti...
File
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc
(right):

https://codereview.chromium.org/596053003/diff/180001/components/data_reducti...
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc:64:
const Client client,
On 2014/10/02 17:36:07, bengr1 wrote:
> "const" isn't needed here.

Done.

https://codereview.chromium.org/596053003/diff/180001/components/data_reducti...
File
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler_unittest.cc
(right):

https://codereview.chromium.org/596053003/diff/180001/components/data_reducti...
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler_unittest.cc:96:
const Client client,
On 2014/10/02 17:36:07, bengr1 wrote:
> "const" isn't needed here.

Done.

[Not at Google. Contact bengr, 2014-10-02 18:48:37]

The CQ bit was checked by kundaji@chromium.org

[commit-bot: I haz the power, 2014-10-02 18:49:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596053003/200001

[Not at Google. Contact bengr, 2014-10-02 18:56:39]

kundaji@chromium.org changed reviewers:
+ boliu@chromium.org

[Not at Google. Contact bengr, 2014-10-02 18:57:30]

boliu:
 android_webview/*

[Not at Google. Contact bengr, 2014-10-02 18:58:06]

The CQ bit was unchecked by kundaji@chromium.org

[boliu, 2014-10-02 19:36:45]

On 2014/10/02 18:57:30, kundaji wrote:
> boliu:
>  android_webview/*

lgtm

[Not at Google. Contact bengr, 2014-10-02 20:05:36]

The CQ bit was checked by kundaji@chromium.org

[commit-bot: I haz the power, 2014-10-02 20:05:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596053003/200001

[commit-bot: I haz the power, 2014-10-02 20:12:01]

Committed patchset #11 (id:200001) as 481969fecd048a691aac5b063f154d01370aab6f

[commit-bot: I haz the power, 2014-10-02 20:12:31]

Patchset 11 (id:??) landed as
https://crrev.com/d650ae28dae3a4c9d6073224d03705c0ff7a9fdf
Cr-Commit-Position: refs/heads/master@{#297885}