Add client type in chrome-proxy header for desktop.

components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_split.h"
@@ skipping 13 matching lines @@
 #include "url/gurl.h"
 
 namespace data_reduction_proxy {
 
 // The empty version for the authentication protocol. Currently used by
 // Android webview.
 #if defined(OS_ANDROID)
 const char kAndroidWebViewProtocolVersion[] = "";
 #endif
 
-// The clients supported by the data reduction proxy.
-const char kClientAndroidWebview[] = "webview";
-const char kClientChromeAndroid[] = "android";
-const char kClientChromeIOS[] = "ios";
+#define CLIENT_ENUM(name, str_value) \
+    case name: return str_value;
+const char* GetString(Client client) {
+  switch (client) {
+    CLIENT_ENUMS_LIST
+  }
+  NOTREACHED();
+  return "";
+}
+#undef CLIENT_ENUM
 
 // static
 bool DataReductionProxyAuthRequestHandler::IsKeySetOnCommandLine() {
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   return command_line.HasSwitch(
       data_reduction_proxy::switches::kDataReductionProxyKey);
 }
 
 DataReductionProxyAuthRequestHandler::DataReductionProxyAuthRequestHandler(
-    const std::string& client,
+    const Client client,
     DataReductionProxyParams* params,
     scoped_refptr<base::SingleThreadTaskRunner> network_task_runner)
-    : client_(client),
+    : client_(GetString(client)),
       data_reduction_proxy_params_(params),
       network_task_runner_(network_task_runner) {
   GetChromiumBuildAndPatch(ChromiumVersion(), &build_number_, &patch_number_);
   Init();
 }
 
 DataReductionProxyAuthRequestHandler::DataReductionProxyAuthRequestHandler(
-    const std::string& client,
+    const Client client,

[bengr, 2014/10/02 17:36:07]

"const" isn't needed here.

[Not at Google. Contact bengr, 2014/10/02 18:07:44]

Done.

     const std::string& version,
     DataReductionProxyParams* params,
     scoped_refptr<base::SingleThreadTaskRunner> network_task_runner)
-    : client_(client),
+    : client_(GetString(client)),
       data_reduction_proxy_params_(params),
       network_task_runner_(network_task_runner) {
   GetChromiumBuildAndPatch(version, &build_number_, &patch_number_);
   Init();
 }
 
 std::string DataReductionProxyAuthRequestHandler::ChromiumVersion() const {
 #if defined(PRODUCT_VERSION)
   return PRODUCT_VERSION;
 #else
@@ skipping 153 matching lines @@
   if (data_reduction_proxy_params_ &&
       data_reduction_proxy_params_->IsDataReductionProxy(proxy_server, NULL) &&
       net::HostPortPair::FromURL(
           data_reduction_proxy_params_->ssl_origin()).Equals(
               proxy_server) == expect_ssl) {
     AddAuthorizationHeader(request_headers);
   }
 }
 
 }  // namespace data_reduction_proxy