Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 596023003: Revert "I need this change to create Windows 8.1/Windows Phone 8.1 projects that compile modules th… (Closed)

Created:
4 years, 12 months ago by scottmg
Modified:
4 years, 12 months ago
Reviewers:
coop
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Revert "I need this change to create Windows 8.1/Windows Phone 8.1 projects that compile modules that can be consumed by Windows Store Applications (WinRT)." This reverts commit 397b1c684b0b07a38f485f091cc4394a3d733334. Failing on win64 bots per http://build.chromium.org/p/tryserver.nacl/builders/gyp-win64/builds/1896 BUG= Committed: https://code.google.com/p/gyp/source/detail?r=1983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -149 lines) Patch
M pylib/gyp/generator/msvs.py View 5 chunks +9 lines, -34 lines 0 comments Download
D test/win/enable-winrt/dllmain.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D test/win/enable-winrt/enable-winrt.gyp View 1 chunk +0 lines, -42 lines 0 comments Download
D test/win/gyptest-link-enable-winrt.py View 1 chunk +0 lines, -31 lines 0 comments Download
M test/win/gyptest-link-target-machine.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/win/linker-flags/target-machine.gyp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scottmg
Committed patchset #1 (id:1) manually as 1983.
4 years, 12 months ago (2014-09-24 20:14:38 UTC) #2
scottmg
Hi Cooper, I had to revert this as it's making the bots red. If you ...
4 years, 12 months ago (2014-09-24 20:14:55 UTC) #3
coop
Is there a way we could condition the test to not generate for the other ...
4 years, 12 months ago (2014-09-24 20:35:30 UTC) #4
coop
4 years, 12 months ago (2014-09-24 20:42:25 UTC) #5
Message was sent while issue was closed.
On 2014/09/24 20:35:30, coop wrote:
> Is there a way we could condition the test to not generate for the other VS
> compilers?  WinRT is only supported on VS2013.
> 
> This error is because the SDK would not exist for those compiler
configurations.
> 
> "dllmain.cc(6): fatal error C1083: Cannot open include file: 'wrl.h': No such
> file or directory"

Looks like the other failures might be a result of the missing ARM TargetMachine
thing that was reverted?

I think we can preserve the actual winrt change if we can get the test to only
be used in a VS2013 validation test run.  
The winrt-specific options would be invalid anyway for other VS projects.

Is this possible?

Powered by Google App Engine
This is Rietveld 408576698