extensions/common/permissions/extensions_api_permissions.cc - Issue 596003002: Allow declarative webrequest and webrequest in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/extensions_api_permissions.cc

Issue 596003002: Allow declarative webrequest and webrequest in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up RuleRegistry in ExtensionsApiClient. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/declarative/rules_registry_service.cc ('K') | « extensions/common/api/web_view_request.json ('k') | extensions/extensions.gyp » ('j') | extensions/shell/common/shell_extensions_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/extensions_api_permissions.cc

diff --git a/extensions/common/permissions/extensions_api_permissions.cc b/extensions/common/permissions/extensions_api_permissions.cc

index 498990ce3949ee878ea84ef615b213068b7a1bae..c4cac3f3996420e7cde4a0b7562829889910cbc5 100644

--- a/extensions/common/permissions/extensions_api_permissions.cc

+++ b/extensions/common/permissions/extensions_api_permissions.cc

@@ -35,6 +35,10 @@ std::vector<APIPermissionInfo*> ExtensionsAPIPermissions::GetAllPermissions()

{APIPermission::kAudioCapture, "audioCapture",

APIPermissionInfo::kFlagNone, IDS_EXTENSION_PROMPT_WARNING_AUDIO_CAPTURE,

PermissionMessage::kAudioCapture},

+ {APIPermission::kDeclarativeWebRequest, "declarativeWebRequest",

+ APIPermissionInfo::kFlagNone,

+ IDS_EXTENSION_PROMPT_WARNING_DECLARATIVE_WEB_REQUEST,

+ PermissionMessage::kDeclarativeWebRequest},

{APIPermission::kDns, "dns"},

{APIPermission::kExternallyConnectableAllUrls,

"externally_connectable.all_urls"},

@@ -77,6 +81,8 @@ std::vector<APIPermissionInfo*> ExtensionsAPIPermissions::GetAllPermissions()

APIPermissionInfo::kFlagInternal,

IDS_EXTENSION_PROMPT_WARNING_WEB_CONNECTABLE,

PermissionMessage::kWebConnectable},

+ {APIPermission::kWebRequest, "webRequest"},

+ {APIPermission::kWebRequestBlocking, "webRequestBlocking"},

{APIPermission::kWebView, "webview",

APIPermissionInfo::kFlagCannotBeOptional},

{APIPermission::kWindowShape, "app.window.shape"},