extensions/shell/common/shell_extensions_client.cc - Issue 596003002: Allow declarative webrequest and webrequest in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/common/shell_extensions_client.cc

Issue 596003002: Allow declarative webrequest and webrequest in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up RuleRegistry in ExtensionsApiClient. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/declarative/rules_registry_service.cc ('K') | « extensions/renderer/resources/web_view_request_custom_bindings.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/common/shell_extensions_client.cc

diff --git a/extensions/shell/common/shell_extensions_client.cc b/extensions/shell/common/shell_extensions_client.cc

index 039841320dd8215f6899af07bdbd9d75effda48b..503dae27d2675780bd0f44536f1bb3b195f98643 100644

--- a/extensions/shell/common/shell_extensions_client.cc

+++ b/extensions/shell/common/shell_extensions_client.cc

@@ -8,6 +8,7 @@

#include "base/logging.h"

#include "extensions/common/api/generated_schemas.h"

#include "extensions/common/common_manifest_handlers.h"

+#include "extensions/common/extension_api.h"

#include "extensions/common/extension_urls.h"

#include "extensions/common/features/api_feature.h"

#include "extensions/common/features/base_feature_provider.h"

@@ -181,6 +182,10 @@ base::StringPiece ShellExtensionsClient::GetAPISchema(

void ShellExtensionsClient::RegisterAPISchemaResources(

ExtensionAPI* api) const {

+ api->RegisterSchemaResource("declarativeWebRequest",

Ken Rockot(use gerrit already) 2014/09/29 17:22:53 You could also remove these from both ShellExtensi

Xi Han 2014/09/29 18:16:21 Great suggestion! I was considering how to remove

+ IDR_EXTENSION_API_JSON_DECLARATIVE_WEBREQUEST);

+ api->RegisterSchemaResource("webViewRequest",

+ IDR_EXTENSION_API_JSON_WEB_VIEW_REQUEST);

}

bool ShellExtensionsClient::ShouldSuppressFatalErrors() const {

« extensions/browser/api/declarative/rules_registry_service.cc ('K') | « extensions/renderer/resources/web_view_request_custom_bindings.js ('k') | no next file » | no next file with comments »