extensions/browser/api/extensions_api_client.h - Issue 596003002: Allow declarative webrequest and webrequest in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/extensions_api_client.h

Issue 596003002: Allow declarative webrequest and webrequest in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up RuleRegistry in ExtensionsApiClient. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/declarative/rules_registry_service.cc ('K') | « extensions/browser/api/declarative/rules_registry_service.cc ('k') | extensions/browser/api/extensions_api_client.cc » ('j') | extensions/shell/common/shell_extensions_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/extensions_api_client.h

diff --git a/extensions/browser/api/extensions_api_client.h b/extensions/browser/api/extensions_api_client.h

index 7fc2c1c7f048c3cf31e3b46e77cba1baf40c9735..878555b2a6ead5ff6ec4fd9269a4d6a94661cdd2 100644

--- a/extensions/browser/api/extensions_api_client.h

+++ b/extensions/browser/api/extensions_api_client.h

@@ -86,13 +86,6 @@ class ExtensionsAPIClient {

CreateWebViewPermissionHelperDelegate (

WebViewPermissionHelper* web_view_permission_helper) const;

- // TODO(wjmaclean): Remove this as soon as rules_registry_service.* moves to

- // extensions/browser/api/declarative/.

- virtual scoped_refptr<RulesRegistry> GetRulesRegistry(

- content::BrowserContext* browser_context,

- const RulesRegistry::WebViewKey& webview_key,

- const std::string& event_name);

// Creates a delegate for WebRequestEventRouter.

virtual WebRequestEventRouterDelegate* CreateWebRequestEventRouterDelegate()

const;