Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3423)

Unified Diff: cc/scheduler/scheduler_settings.cc

Issue 595973002: Moving background animation ticking from LayerTreeHostImpl into the Scheduler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scheduler-timesource-refactor
Patch Set: ALL TESTS PASS LOCALLY!!!! Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/scheduler_settings.cc
diff --git a/cc/scheduler/scheduler_settings.cc b/cc/scheduler/scheduler_settings.cc
index ab9add087bd9f32bca15c18081d18688ac1d4d9c..95294ad3713d5847b206d0d4b9de7181885fb56c 100644
--- a/cc/scheduler/scheduler_settings.cc
+++ b/cc/scheduler/scheduler_settings.cc
@@ -17,7 +17,8 @@ SchedulerSettings::SchedulerSettings()
maximum_number_of_failed_draws_before_draw_is_forced_(3),
using_synchronous_renderer_compositor(false),
throttle_frame_production(true),
- disable_hi_res_timer_tasks_on_battery(false) {
+ disable_hi_res_timer_tasks_on_battery(false),
+ background_frame_interval(base::TimeDelta::FromSeconds(1)) {
}
SchedulerSettings::SchedulerSettings(const LayerTreeSettings& settings)
@@ -33,7 +34,9 @@ SchedulerSettings::SchedulerSettings(const LayerTreeSettings& settings)
settings.using_synchronous_renderer_compositor),
throttle_frame_production(settings.throttle_frame_production),
disable_hi_res_timer_tasks_on_battery(
- settings.disable_hi_res_timer_tasks_on_battery) {
+ settings.disable_hi_res_timer_tasks_on_battery),
+ background_frame_interval(base::TimeDelta::FromSecondsD(
+ 1.0 / settings.background_animation_rate)) {
brianderson 2014/11/04 18:54:38 Should we rename the LT setting?
mithro-old 2014/11/04 22:16:50 I think the "background_frame_interval" and "backg
brianderson 2014/11/04 23:32:19 Don't care too much. It also guess it's nice that
mithro-old 2014/11/05 00:02:36 Yeah, that is why I chose that name. This change
}
SchedulerSettings::~SchedulerSettings() {}
@@ -56,6 +59,8 @@ SchedulerSettings::AsValue() const {
state->SetBoolean("throttle_frame_production", throttle_frame_production);
state->SetBoolean("disable_hi_res_timer_tasks_on_battery",
disable_hi_res_timer_tasks_on_battery);
+ state->SetInteger("background_frame_interval",
+ background_frame_interval.InMicroseconds());
return state;
}

Powered by Google App Engine
This is Rietveld 408576698