Moving background animation ticking from LayerTreeHostImpl into the Scheduler.

cc/scheduler/scheduler_settings.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/scheduler/scheduler_settings.h"
 
 #include "base/debug/trace_event_argument.h"
 #include "cc/trees/layer_tree_settings.h"
 
 namespace cc {
 
 SchedulerSettings::SchedulerSettings()
     : begin_frame_scheduling_enabled(true),
       main_frame_before_activation_enabled(false),
       impl_side_painting(false),
       timeout_and_draw_when_animation_checkerboards(true),
       maximum_number_of_failed_draws_before_draw_is_forced_(3),
       using_synchronous_renderer_compositor(false),
       throttle_frame_production(true),
-      disable_hi_res_timer_tasks_on_battery(false) {
+      disable_hi_res_timer_tasks_on_battery(false),
+      background_frame_interval(base::TimeDelta::FromSeconds(1)) {
 }
 
 SchedulerSettings::SchedulerSettings(const LayerTreeSettings& settings)
     : begin_frame_scheduling_enabled(settings.begin_frame_scheduling_enabled),
       main_frame_before_activation_enabled(
           settings.main_frame_before_activation_enabled),
       impl_side_painting(settings.impl_side_painting),
       timeout_and_draw_when_animation_checkerboards(
           settings.timeout_and_draw_when_animation_checkerboards),
       maximum_number_of_failed_draws_before_draw_is_forced_(
           settings.maximum_number_of_failed_draws_before_draw_is_forced_),
       using_synchronous_renderer_compositor(
           settings.using_synchronous_renderer_compositor),
       throttle_frame_production(settings.throttle_frame_production),
       disable_hi_res_timer_tasks_on_battery(
-          settings.disable_hi_res_timer_tasks_on_battery) {
+          settings.disable_hi_res_timer_tasks_on_battery),
+      background_frame_interval(base::TimeDelta::FromSecondsD(
+          1.0 / settings.background_animation_rate)) {

[brianderson, 2014/11/04 18:54:38]

Should we rename the LT setting?

[mithro-old, 2014/11/04 22:16:50]

I think the "background_frame_interval" and "background_animation_rate" are
actually slightly different concepts which are related at the moment but might
not be in the future.

If you think they are the same, then I'm happy to change to one name or the
other.

(Also rate verse interval?)

[brianderson, 2014/11/04 23:32:19]

Don't care too much. It also guess it's nice that background_animation_rate
matches it's neighbor refresh_rate in the list of settings it belongs to.

[mithro-old, 2014/11/05 00:02:36]

Yeah, that is why I chose that name. 

This change (which I did to make the testing work) actually sets up the
possibility of having the background ticking length more configurable, which is
nice.

 }
 
 SchedulerSettings::~SchedulerSettings() {}
 
 scoped_refptr<base::debug::ConvertableToTraceFormat>
 SchedulerSettings::AsValue() const {
   scoped_refptr<base::debug::TracedValue> state =
       new base::debug::TracedValue();
   state->SetBoolean("begin_frame_scheduling_enabled",
                     begin_frame_scheduling_enabled);
   state->SetBoolean("main_frame_before_activation_enabled",
                     main_frame_before_activation_enabled);
   state->SetBoolean("impl_side_painting", impl_side_painting);
   state->SetBoolean("timeout_and_draw_when_animation_checkerboards",
                     timeout_and_draw_when_animation_checkerboards);
   state->SetInteger("maximum_number_of_failed_draws_before_draw_is_forced_",
                     maximum_number_of_failed_draws_before_draw_is_forced_);
   state->SetBoolean("using_synchronous_renderer_compositor",
                     using_synchronous_renderer_compositor);
   state->SetBoolean("throttle_frame_production", throttle_frame_production);
   state->SetBoolean("disable_hi_res_timer_tasks_on_battery",
                     disable_hi_res_timer_tasks_on_battery);
+  state->SetInteger("background_frame_interval",
+                    background_frame_interval.InMicroseconds());
   return state;
 }
 
 }  // namespace cc