Fix bug in MIPS BoxInt32 instruction.

runtime/vm/assembler_mips.h

Index: runtime/vm/assembler_mips.h
===================================================================
--- runtime/vm/assembler_mips.h	(revision 40545)
+++ runtime/vm/assembler_mips.h	(working copy)
@@ -928,6 +928,10 @@
     }
   }
 
+  void BranchEqual(Register rd, Register rn, Label* l) {
+    beq(rd, rn, l);
+  }
+
   void BranchEqual(Register rd, int32_t value, Label* l) {

[Ivan Posva, 2014/09/23 14:31:43]

The real issue is that we are not using Immediate here and a lot of other
similar places.

[Vyacheslav Egorov (Google), 2014/09/23 14:42:31]

Alternative interpretation could be: we should make Register itself non
coerciable to int (at least in DEBUG builds)?

This would allow us to catch issues like this at compilation time.

     ASSERT(!in_delay_slot_);
     if (value == 0) {
@@ -946,6 +950,10 @@
     beq(rd, CMPRES2, l);
   }
 
+  void BranchNotEqual(Register rd, Register rn, Label* l) {
+    bne(rd, rn, l);
+  }
+
   void BranchNotEqual(Register rd, int32_t value, Label* l) {
     ASSERT(!in_delay_slot_);
     if (value == 0) {