Fix bug in MIPS BoxInt32 instruction.

runtime/vm/assembler_mips.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ASSEMBLER_MIPS_H_
 #define VM_ASSEMBLER_MIPS_H_
 
 #ifndef VM_ASSEMBLER_H_
 #error Do not include assembler_mips.h directly; use assembler.h instead.
 #endif
@@ skipping 910 matching lines @@
     }
 
     if (Utils::IsUint(kImmBits, imm)) {
       andi(rd, rs, Immediate(imm));
     } else {
       LoadImmediate(TMP, imm);
       and_(rd, rs, TMP);
     }
   }
 
+  void BranchEqual(Register rd, Register rn, Label* l) {
+    beq(rd, rn, l);
+  }
+
   void BranchEqual(Register rd, int32_t value, Label* l) {

[Ivan Posva, 2014/09/23 14:31:43]

The real issue is that we are not using Immediate here and a lot of other
similar places.

[Vyacheslav Egorov (Google), 2014/09/23 14:42:31]

Alternative interpretation could be: we should make Register itself non
coerciable to int (at least in DEBUG builds)?

This would allow us to catch issues like this at compilation time.

     ASSERT(!in_delay_slot_);
     if (value == 0) {
       beq(rd, ZR, l);
     } else {
       ASSERT(rd != CMPRES2);
       LoadImmediate(CMPRES2, value);
       beq(rd, CMPRES2, l);
     }
   }
 
   void BranchEqual(Register rd, const Object& object, Label* l) {
     ASSERT(!in_delay_slot_);
     ASSERT(rd != CMPRES2);
     LoadObject(CMPRES2, object);
     beq(rd, CMPRES2, l);
   }
 
+  void BranchNotEqual(Register rd, Register rn, Label* l) {
+    bne(rd, rn, l);
+  }
+
   void BranchNotEqual(Register rd, int32_t value, Label* l) {
     ASSERT(!in_delay_slot_);
     if (value == 0) {
       bne(rd, ZR, l);
     } else {
       ASSERT(rd != CMPRES2);
       LoadImmediate(CMPRES2, value);
       bne(rd, CMPRES2, l);
     }
   }
@@ skipping 437 matching lines @@
                                   Register value,
                                   Label* no_update);
 
   DISALLOW_ALLOCATION();
   DISALLOW_COPY_AND_ASSIGN(Assembler);
 };
 
 }  // namespace dart
 
 #endif  // VM_ASSEMBLER_MIPS_H_