The MediatorThread worker thread needs to have a CertVerifier...

The MediatorThread worker thread needs to have a CertVerifier
for the SSLClientSocket objects it creates.

R=agl,akalin
BUG=63357, 67239
TEST=Sync should not crash.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69549

[wtc, 2010-12-17 06:22:07]

agl,akalin: please review.

hclam: just FYI.

Please review the files in this order, which reflects the
plumbing of the cert verifier:

  mediator_thread_impl.{h,cc}
  login.{h,cc}
  login_settings.{h,cc}
  single_login_attempt.cc
  xmpp_connection.{h,cc}
  chrome_async_socket.{h,cc}

[akalin, 2010-12-17 06:36:08]

LGTM

http://codereview.chromium.org/5958001/diff/13001/jingle/notifier/base/chrome...
File jingle/notifier/base/chrome_async_socket.h (left):

http://codereview.chromium.org/5958001/diff/13001/jingle/notifier/base/chrome...
jingle/notifier/base/chrome_async_socket.h:39:
ChromeAsyncSocket(net::ClientSocketFactory* client_socket_factory,
You'll need to change the constructor call in the unit test.

http://codereview.chromium.org/5958001/diff/13001/jingle/notifier/base/chrome...
File jingle/notifier/base/chrome_async_socket.h (right):

http://codereview.chromium.org/5958001/diff/13001/jingle/notifier/base/chrome...
jingle/notifier/base/chrome_async_socket.h:42: net::CertVerifier *cert_verifier,
'Verifier *' -> "Verifier* '

[wtc, 2010-12-17 16:03:35]

akalin: I addressed your review comments in Patch Set 5.
Please review.  (You can just review the diffs between
Patch Sets 2 and 5.)  Thanks.

[agl, 2010-12-17 16:22:01]

LGTM

http://codereview.chromium.org/5958001/diff/48001/chrome/browser/sync/tools/s...
File chrome/browser/sync/tools/sync_listen_notifications.cc (right):

http://codereview.chromium.org/5958001/diff/48001/chrome/browser/sync/tools/s...
chrome/browser/sync/tools/sync_listen_notifications.cc:302: 
(very minor): I would remove this blank line.

http://codereview.chromium.org/5958001/diff/48001/jingle/notifier/base/chrome...
File jingle/notifier/base/chrome_async_socket.h (right):

http://codereview.chromium.org/5958001/diff/48001/jingle/notifier/base/chrome...
jingle/notifier/base/chrome_async_socket.h:38: // Takes ownership of
|client_socket_factory| but not |cert_verifier| and
s/and/nor/

http://codereview.chromium.org/5958001/diff/48001/jingle/notifier/base/chrome...
jingle/notifier/base/chrome_async_socket.h:192: net::CertVerifier*
cert_verifier_;
I think this can be a const pointer if you like that sort of thing.

http://codereview.chromium.org/5958001/diff/48001/jingle/notifier/communicato...
File jingle/notifier/communicator/login_settings.h (right):

http://codereview.chromium.org/5958001/diff/48001/jingle/notifier/communicato...
jingle/notifier/communicator/login_settings.h:81: net::CertVerifier*
cert_verifier_;
likewise about the const pointer if you like them.