Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 595783003: Make ScreenOrientationController a FrameDestructionObserver. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make ScreenOrientationController a FrameDestructionObserver. With LocalFrame now on the heap, switch this controller to be a frame destruction observer so as to conventionally handle tracing of the frame during GCs, and eventual frame detach. This is a tidying change; what's currently provided isn't unsafe, as the controller is also a page lifecycle observer and uses the lack of a page to detect detached operation. But it is preferable overall to handle frame access and lifetime using FrameDestructionObserver. R=haraken,mlamouri BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182497

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename predicate to isActiveAndVisible() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M Source/modules/screen_orientation/ScreenOrientation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 1 6 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
sof
Please take a look.
6 years, 2 months ago (2014-09-23 08:03:03 UTC) #2
haraken
What's a criteria where you want to use FrameDestructionObserver? If a class A has 'LocalFrame& ...
6 years, 2 months ago (2014-09-23 08:23:05 UTC) #4
sof
On 2014/09/23 08:23:05, haraken wrote: > What's a criteria where you want to use FrameDestructionObserver? ...
6 years, 2 months ago (2014-09-23 08:50:30 UTC) #5
haraken
On 2014/09/23 08:50:30, sof wrote: > On 2014/09/23 08:23:05, haraken wrote: > > What's a ...
6 years, 2 months ago (2014-09-23 08:51:55 UTC) #6
sof
On 2014/09/23 08:51:55, haraken wrote: > On 2014/09/23 08:50:30, sof wrote: > > On 2014/09/23 ...
6 years, 2 months ago (2014-09-23 09:01:02 UTC) #7
mlamouri (slow - plz ping)
lgtm with the rename https://codereview.chromium.org/595783003/diff/1/Source/modules/screen_orientation/ScreenOrientationController.cpp File Source/modules/screen_orientation/ScreenOrientationController.cpp (right): https://codereview.chromium.org/595783003/diff/1/Source/modules/screen_orientation/ScreenOrientationController.cpp#newcode94 Source/modules/screen_orientation/ScreenOrientationController.cpp:94: bool ScreenOrientationController::isActive() const Could you ...
6 years, 2 months ago (2014-09-23 10:29:49 UTC) #8
sof
Thanks for the quick reviews! :) https://codereview.chromium.org/595783003/diff/1/Source/modules/screen_orientation/ScreenOrientationController.cpp File Source/modules/screen_orientation/ScreenOrientationController.cpp (right): https://codereview.chromium.org/595783003/diff/1/Source/modules/screen_orientation/ScreenOrientationController.cpp#newcode94 Source/modules/screen_orientation/ScreenOrientationController.cpp:94: bool ScreenOrientationController::isActive() const ...
6 years, 2 months ago (2014-09-23 12:48:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/595783003/20001
6 years, 2 months ago (2014-09-23 12:49:07 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-23 13:51:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182497

Powered by Google App Engine
This is Rietveld 408576698