Source/modules/screen_orientation/ScreenOrientation.cpp - Issue 595783003: Make ScreenOrientationController a FrameDestructionObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.cpp

Issue 595783003: Make ScreenOrientationController a FrameDestructionObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename predicate to isActiveAndVisible() Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/screen_orientation/ScreenOrientation.cpp

diff --git a/Source/modules/screen_orientation/ScreenOrientation.cpp b/Source/modules/screen_orientation/ScreenOrientation.cpp

index b06318aee0a470e2b9f4836c237d443774fd533f..0172e47e2fe29d1d00ef5bd28a7fd6826cbd2f87 100644

--- a/Source/modules/screen_orientation/ScreenOrientation.cpp

+++ b/Source/modules/screen_orientation/ScreenOrientation.cpp

@@ -93,7 +93,7 @@ ScreenOrientation* ScreenOrientation::create(LocalFrame* frame)

// FIXME: ideally, we would like to provide the ScreenOrientationController

// the case where it is not defined but for the moment, it is eagerly

// created when the LocalFrame is created so we shouldn't be in that

- // situtaion.

+ // situation.

// In order to create the ScreenOrientationController lazily, we would need

// to be able to access WebFrameClient from modules/.

« no previous file with comments | « no previous file | Source/modules/screen_orientation/ScreenOrientationController.h » ('j') | no next file with comments »