Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 595763002: history: add a browser test for confirm dialog focus regression. (Closed)

Created:
6 years, 3 months ago by Dan Beam
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@history-focus
Project:
chromium
Visibility:
Public.

Description

history: add a browser test for confirm dialog focus regression. R=estade@chromium.org BUG=407498

Patch Set 1 #

Patch Set 2 : better test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/resources/history/history.js View 2 chunks +2 lines, -0 lines 2 comments Download
M chrome/test/data/webui/history_browsertest.js View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
6 years, 3 months ago (2014-09-23 05:17:48 UTC) #1
Evan Stade
https://codereview.chromium.org/595763002/diff/20001/chrome/browser/resources/history/history.js File chrome/browser/resources/history/history.js (right): https://codereview.chromium.org/595763002/diff/20001/chrome/browser/resources/history/history.js#newcode1979 chrome/browser/resources/history/history.js:1979: $('history-page').setAttribute('aria-hidden', 'true'); is this related to the CL desc?
6 years, 3 months ago (2014-09-23 20:46:31 UTC) #2
Dan Beam
https://codereview.chromium.org/595763002/diff/20001/chrome/browser/resources/history/history.js File chrome/browser/resources/history/history.js (right): https://codereview.chromium.org/595763002/diff/20001/chrome/browser/resources/history/history.js#newcode1979 chrome/browser/resources/history/history.js:1979: $('history-page').setAttribute('aria-hidden', 'true'); On 2014/09/23 20:46:30, Evan Stade wrote: > ...
6 years, 3 months ago (2014-09-23 20:48:42 UTC) #3
Dan Beam
6 years, 3 months ago (2014-09-23 21:00:23 UTC) #4
Message was sent while issue was closed. 
closing and folding this into https://codereview.chromium.org/591353002/

Powered by Google App Engine
This is Rietveld 408576698