Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: chrome/browser/resources/history/history.js

Issue 595763002: history: add a browser test for confirm dialog focus regression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history-focus
Patch Set: better test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/history_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history/history.js
diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js
index d57b119d8ba83da4edd8d730ed397f44bc883328..87bb0b07d7c398d09777d52b46e324783f0737ed 100644
--- a/chrome/browser/resources/history/history.js
+++ b/chrome/browser/resources/history/history.js
@@ -1976,6 +1976,7 @@ function showConfirmationOverlay() {
$('alertOverlay').classList.add('showing');
$('overlay').hidden = false;
$('alertOverlayCancel').focus();
+ $('history-page').setAttribute('aria-hidden', 'true');
Evan Stade 2014/09/23 20:46:30 is this related to the CL desc?
Dan Beam 2014/09/23 20:48:42 yeah, because it's required to pass the browser te
uber.invokeMethodOnParent('beginInterceptingEvents');
}
@@ -1985,6 +1986,7 @@ function showConfirmationOverlay() {
function hideConfirmationOverlay() {
$('alertOverlay').classList.remove('showing');
$('overlay').hidden = true;
+ $('history-page').removeAttribute('aria-hidden');
uber.invokeMethodOnParent('stopInterceptingEvents');
}
« no previous file with comments | « no previous file | chrome/test/data/webui/history_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698