Gather metrics on hosted app unlimitedStorage usage

Gather metrics on hosted app unlimitedStorage usage

BUG=416691
Committed: https://crrev.com/87110ad38310dc8ec3a25a9091b6159cf279e193
Cr-Commit-Position: refs/heads/master@{#296298}

[Devlin, 2014-09-23 15:43:58]

rdevlin.cronin@chromium.org changed reviewers:
+ jyasskin@chromium.org

[Devlin, 2014-09-23 15:43:58]

Jeffrey, mind taking a quick look?

[Jeffrey Yasskin, 2014-09-23 16:35:59]

lgtm

[Devlin, 2014-09-23 16:36:34]

rdevlin.cronin@chromium.org changed reviewers:
+ mpearson@chromium.org

[Devlin, 2014-09-23 16:36:34]

Mark, mind checking histograms?

[Mark P, 2014-09-23 17:12:58]

https://codereview.chromium.org/595683002/diff/1/extensions/browser/api/stora...
File extensions/browser/api/storage/local_value_store_cache.cc (right):

https://codereview.chromium.org/595683002/diff/1/extensions/browser/api/stora...
extensions/browser/api/storage/local_value_store_cache.cc:101:
UMA_HISTOGRAM_COUNTS_100("Extensions.HostedAppUnlimitedStorageUsage",
Are you sure you don't want one of the _MEMORY_ histograms?

https://codereview.chromium.org/595683002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/595683002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:7642: +<histogram
name="Extensions.HostedAppUnlimitedStorageUsage" units="kilobytes">
Usually for better table formatting we use the shorter
units="KB"

[Devlin, 2014-09-23 20:58:04]

https://codereview.chromium.org/595683002/diff/1/extensions/browser/api/stora...
File extensions/browser/api/storage/local_value_store_cache.cc (right):

https://codereview.chromium.org/595683002/diff/1/extensions/browser/api/stora...
extensions/browser/api/storage/local_value_store_cache.cc:101:
UMA_HISTOGRAM_COUNTS_100("Extensions.HostedAppUnlimitedStorageUsage",
On 2014/09/23 17:12:58, Mark P wrote:
> Are you sure you don't want one of the _MEMORY_ histograms?

Oh, didn't know those existed.  Done.  (To confirm, the histogram now does the
bytes -> KB conversion, right?)

https://codereview.chromium.org/595683002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/595683002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:7642: +<histogram
name="Extensions.HostedAppUnlimitedStorageUsage" units="kilobytes">
On 2014/09/23 17:12:58, Mark P wrote:
> Usually for better table formatting we use the shorter
> units="KB"

Done.

[Mark P, 2014-09-23 22:07:51]

lgtm

https://codereview.chromium.org/595683002/diff/1/extensions/browser/api/stora...
File extensions/browser/api/storage/local_value_store_cache.cc (right):

https://codereview.chromium.org/595683002/diff/1/extensions/browser/api/stora...
extensions/browser/api/storage/local_value_store_cache.cc:101:
UMA_HISTOGRAM_COUNTS_100("Extensions.HostedAppUnlimitedStorageUsage",
On 2014/09/23 20:58:03, Devlin wrote:
> On 2014/09/23 17:12:58, Mark P wrote:
> > Are you sure you don't want one of the _MEMORY_ histograms?
> 
> Oh, didn't know those existed.  Done.  (To confirm, the histogram now does the
> bytes -> KB conversion, right?)

Looking at the code, it appears the answer is yes, it does the conversion for
you.

[Devlin, 2014-09-23 22:21:25]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-09-23 22:22:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/595683002/20001

[commit-bot: I haz the power, 2014-09-23 23:35:34]

Committed patchset #2 (id:20001) as 65e4b9155776a1feff14d7e14fca5bcd1d6c9c91

[commit-bot: I haz the power, 2014-09-23 23:36:03]

Patchset 2 (id:??) landed as
https://crrev.com/87110ad38310dc8ec3a25a9091b6159cf279e193
Cr-Commit-Position: refs/heads/master@{#296298}