Gather metrics on hosted app unlimitedStorage usage

extensions/browser/api/storage/local_value_store_cache.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/storage/local_value_store_cache.h"
 
 #include <limits>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/file_path.h"
+#include "base/metrics/histogram.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/browser/api/storage/settings_storage_factory.h"
 #include "extensions/browser/api/storage/settings_storage_quota_enforcer.h"
 #include "extensions/browser/api/storage/weak_unlimited_settings_storage.h"
 #include "extensions/browser/value_store/value_store.h"
 #include "extensions/common/api/storage.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/permissions/api_permission.h"
 #include "extensions/common/permissions/permissions_data.h"
@@ skipping 62 matching lines @@
   StorageMap::iterator iter = storage_map_.find(extension->id());
   if (iter != storage_map_.end())
     return iter->second.get();
 
   const base::FilePath& file_path =
       extension->is_app() ? app_base_path_ : extension_base_path_;
   linked_ptr<SettingsStorageQuotaEnforcer> storage(
       new SettingsStorageQuotaEnforcer(
           quota_, storage_factory_->Create(file_path, extension->id())));
   DCHECK(storage.get());
+
+  if (extension->permissions_data()->HasAPIPermission(
+          APIPermission::kUnlimitedStorage) &&
+      extension->is_hosted_app()) {
+    // We're interested in the amount of space hosted apps are using. Record it
+    // in KB the first time we load the storage for the extension.
+    UMA_HISTOGRAM_COUNTS_100("Extensions.HostedAppUnlimitedStorageUsage",

[Mark P, 2014/09/23 17:12:58]

Are you sure you don't want one of the _MEMORY_ histograms?

[Devlin, 2014/09/23 20:58:03]

Oh, didn't know those existed.  Done.  (To confirm, the histogram now does the
bytes -> KB conversion, right?)

[Mark P, 2014/09/23 22:07:51]

Looking at the code, it appears the answer is yes, it does the conversion for
you.

+                             storage->GetBytesInUse() / 1024);
+  }
+
   storage_map_[extension->id()] = storage;
   return storage.get();
 }
 
 }  // namespace extensions